Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigmoid, tanh and relu should be moved to neural_network/activation_functions from maths/ #9048

Closed
AdarshAcharya5 opened this issue Sep 10, 2023 · 6 comments · Fixed by #9753
Labels
enhancement This PR modified some existing files

Comments

@AdarshAcharya5
Copy link
Contributor

AdarshAcharya5 commented Sep 10, 2023

Feature description

sigmoid.py, tanh.py, sigmoid_linear_unit.py and relu.py should be moved to neural_network/activation_functions.

@AdarshAcharya5 AdarshAcharya5 added the enhancement This PR modified some existing files label Sep 10, 2023
@AdarshAcharya5 AdarshAcharya5 changed the title sigmoid and tanh should be moved to neural_network/activation_functions from maths/ sigmoid, tanh and relu should be moved to neural_network/activation_functions from maths/ Sep 10, 2023
@rohan472000
Copy link
Contributor

@AdarshAcharya5 , why you want to move those .py files?

@anchor54
Copy link

anchor54 commented Oct 1, 2023

is this still a requirement and open for contribution?

@aayushi-0407

This comment was marked as off-topic.

@UjjwalPardeshi

This comment was marked as off-topic.

@tianyizheng02
Copy link
Contributor

@rohan472000 Functions such as sigmoid, tanh, and ReLU are nowadays commonly used as activation functions for neural networks. Sigmoid (or more specifically the logistic function) and tanh are still well-known mathematical functions outside of ML, so I think those should stay in the maths/ directory. However, ReLU is pretty much only known as an activation function as far as I know, so I think it's appropriate to move that algorithm to neural_network/activation_functions.

@piyush-poddar
Copy link
Contributor

Hi I have raised a PR, please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment