-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorts/random_normal_distribution_quicksort.py has no tests #9124
Comments
Explain a bit more about this problem. Maybe I can help. |
If its regarding coming up with viable test cases and ensure running of the algortihm, I can help out! |
Please read CONTRIBUTING.md to understand what this repo requires for tests. |
This comment was marked as off-topic.
This comment was marked as off-topic.
As discussed in CONTRIBUTING.md, we do NOT assign issues. We review pull requests. |
@cclauss I think this file should be deleted entirely. It's just an implementation of quicksort with a random pivot (which we already have), and the only difference is that the array elements themselves follow a normal distribution. For all intents and purposes, it's a duplicate of sorts/random_pivot_quick_sort.py. |
@tianyizheng02 hi, I am a beginner in open source and it is my first time contributing in a big repo like this. So I deleted the file random_normal_distribution_quicksort.py which you said is a copy of the random_pivot_quicksort.py . If I have made any mistakes please feel free to inform me, Thank you. |
Reopening this issue because I just realized that |
Repository commit
3
Python version (python --version)
Python 3.11.5
Dependencies version (pip freeze)
Numpy
Expected behavior
Tests.
Actual behavior
No tests.
The text was updated successfully, but these errors were encountered: