Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorts/random_normal_distribution_quicksort.py has no tests #9124

Closed
cclauss opened this issue Sep 29, 2023 · 9 comments · Fixed by #9178 or #9182
Closed

sorts/random_normal_distribution_quicksort.py has no tests #9124

cclauss opened this issue Sep 29, 2023 · 9 comments · Fixed by #9178 or #9182
Labels
bug require tests Tests [doctest/unittest/pytest] are required

Comments

@cclauss
Copy link
Member

cclauss commented Sep 29, 2023

Repository commit

3

Python version (python --version)

Python 3.11.5

Dependencies version (pip freeze)

Numpy

Expected behavior

Tests.

Actual behavior

No tests.

@cclauss cclauss added bug require tests Tests [doctest/unittest/pytest] are required labels Sep 29, 2023
@cclauss
Copy link
Member Author

cclauss commented Sep 29, 2023

@prateekiiest

@Dev-Arhaan
Copy link

Explain a bit more about this problem. Maybe I can help.

@Avineesh28
Copy link

If its regarding coming up with viable test cases and ensure running of the algortihm, I can help out!

@cclauss
Copy link
Member Author

cclauss commented Sep 30, 2023

Please read CONTRIBUTING.md to understand what this repo requires for tests.

@Rohxn16

This comment was marked as off-topic.

@cclauss
Copy link
Member Author

cclauss commented Sep 30, 2023

As discussed in CONTRIBUTING.md, we do NOT assign issues. We review pull requests.

@tianyizheng02
Copy link
Contributor

@cclauss I think this file should be deleted entirely. It's just an implementation of quicksort with a random pivot (which we already have), and the only difference is that the array elements themselves follow a normal distribution. For all intents and purposes, it's a duplicate of sorts/random_pivot_quick_sort.py.

@Rohxn16 Rohxn16 mentioned this issue Oct 1, 2023
2 tasks
@Rohxn16
Copy link

Rohxn16 commented Oct 1, 2023

@tianyizheng02 hi, I am a beginner in open source and it is my first time contributing in a big repo like this. So I deleted the file random_normal_distribution_quicksort.py which you said is a copy of the random_pivot_quicksort.py . If I have made any mistakes please feel free to inform me, Thank you.

@tianyizheng02
Copy link
Contributor

Reopening this issue because I just realized that quick_sort.py already uses a random pivot, which means that both random_normal_distribution_quicksort.py and random_pivot_quick_sort.py are duplicates and both should be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
5 participants