Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Heap sorting technique #9528

Closed
Soyvor opened this issue Oct 2, 2023 · 3 comments
Closed

Improved Heap sorting technique #9528

Soyvor opened this issue Oct 2, 2023 · 3 comments
Labels
enhancement This PR modified some existing files

Comments

@Soyvor
Copy link

Soyvor commented Oct 2, 2023

Feature description

code you provided is a clear and concise implementation of the heap sort algorithm in Python. However, if you want to make it slightly more concise while preserving readability, you can make a few adjustments.

sign me up for hacktober fest
@Soyvor Soyvor added the enhancement This PR modified some existing files label Oct 2, 2023
@Soyvor Soyvor changed the title Improved Head sorting technique Improved Heap sorting technique Oct 2, 2023
@abhaygzb15

This comment was marked as off-topic.

Sign in to view
@pjbeast23 pjbeast23 mentioned this issue Oct 3, 2023
Closed
14 tasks
Aloneking789 added a commit to Aloneking789/Python that referenced this issue Oct 3, 2023
@Aloneking789
Heap.py
f0f1cc9 
This is the solution to the problem TheAlgorithms#9528
This was referenced Oct 3, 2023
Closed
Closed
@imSanko imSanko mentioned this issue Oct 3, 2023
Closed
14 tasks
@cclauss
Copy link
Member

cclauss commented Oct 4, 2023

  • Keep the doctests and add more.
  • Keep the self-documenting parameter names and add more
  • Add type hints for all function parameters and return types.

@shivamk23 shivamk23 mentioned this issue Oct 4, 2023
Closed
14 tasks
swapnil290502 added a commit to swapnil290502/Python that referenced this issue Oct 4, 2023
@swapnil290502
Create Improved Heap sorting technique TheAlgorithms#9528
a88bcf5 
In this adjusted version, the code is slightly more concise while maintaining readability. The changes include simplifying the conditional statements and loop ranges.
@rodrigondec rodrigondec mentioned this issue Oct 7, 2023
Merged
14 tasks
@Richards-Richie

This comment was marked as off-topic.

Sign in to view
@Saswatsusmoy Saswatsusmoy mentioned this issue Oct 14, 2023
Closed
14 tasks
@cclauss cclauss closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
4 participants
@cclauss @Richards-Richie @Soyvor @abhaygzb15