Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move maths/sigmoid_linear_unit.py to neural_network/activation_functions #9793

Closed
tianyizheng02 opened this issue Oct 5, 2023 · 4 comments · Fixed by #9824
Closed

Move maths/sigmoid_linear_unit.py to neural_network/activation_functions #9793

tianyizheng02 opened this issue Oct 5, 2023 · 4 comments · Fixed by #9824

Comments

@tianyizheng02
Copy link
Contributor

Follow-up from this comment

The sigmoid linear unit function is primarily known as a NN activation function, so it should be moved from the maths directory to the neural_network/activation_functions directory.

Hacktoberfest contributors: if you want to work on this, read the contributing guidelines first and just open a PR. We don't assign issues in this repo.
haxkd added a commit to haxkd/Python that referenced this issue Oct 5, 2023
@haxkd
fix: issue TheAlgorithms#9793
6b47421
@Asif-Sheriff Asif-Sheriff mentioned this issue Oct 5, 2023
Closed
haxkd added a commit to haxkd/Python that referenced this issue Oct 5, 2023
@haxkd
fix: issue TheAlgorithms#9793
e7bc55c
@Asif-Sheriff
Copy link

Hey I am new to open source
I have fixed this issue but when I create a pull request my previous commits are being included
How can I fix this, apologizes for the inconvenience.

cclauss pushed a commit that referenced this issue Oct 5, 2023
@haxkd @pre-commit-ci
convert to the base minus 2 of a number (#9748)
f159a33 
* Fix: Issue 9588

* Fix: Issue 9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue 9588

* Fix: Issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue #9793

* fix: issue #9793

* fix: issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tianyizheng02
Copy link
Contributor Author

When you're working in open source and are working on a new feature, you should always create a new branch and work on the feature on that branch. You should almost never commit directly to the main branch. Creating separate branches for each of your algorithms will prevent them from being added to the same PR.

@AasheeshLikePanner AasheeshLikePanner mentioned this issue Oct 5, 2023
Merged
14 tasks
@AasheeshLikePanner
Copy link
Contributor

Hi, I opened a PR Can you please Check it.

@tianyizheng02 tianyizheng02 linked a pull request Oct 5, 2023 that will close this issue
Changing the directory of sigmoid_linear_unit.py #9824
Merged
14 tasks
ChrisO345 pushed a commit that referenced this issue Oct 5, 2023
@haxkd @pre-commit-ci
Match a pattern and String using backtracking (#9861)
b316a96 
* Fix: Issue 9588

* Fix: Issue 9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue 9588

* Fix: Issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue #9793

* fix: issue #9793

* fix: issue #9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue #9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue #9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue #9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue #9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@Asif-Sheriff
Copy link

@tianyizheng02
Ahh thanks for the clarification mate

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this issue Sep 15, 2024
@haxkd @pre-commit-ci @sedatguzelsemme
convert to the base minus 2 of a number (TheAlgorithms#9748)
99425db 
* Fix: Issue 9588

* Fix: Issue 9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue 9588

* Fix: Issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue TheAlgorithms#9793

* fix: issue TheAlgorithms#9793

* fix: issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this issue Sep 15, 2024
@haxkd @pre-commit-ci @sedatguzelsemme
Match a pattern and String using backtracking (TheAlgorithms#9861)
bdac186 
* Fix: Issue 9588

* Fix: Issue 9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue 9588

* Fix: Issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue TheAlgorithms#9793

* fix: issue TheAlgorithms#9793

* fix: issue TheAlgorithms#9588

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue TheAlgorithms#9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue TheAlgorithms#9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue TheAlgorithms#9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: issue TheAlgorithms#9844

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing the directory of sigmoid_linear_unit.py
3 participants
@tianyizheng02 @AasheeshLikePanner @Asif-Sheriff