Dahhou ilyas #10058
Dahhou ilyas #10058
Conversation
algorithms-keeper
bot
added
enhancement
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class CustomTimeZone(datetime.tzinfo): | ||
| def utcoffset(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: utcoffset. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function utcoffset
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(hours=1) | ||
|
|
||
| def dst(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: dst. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function dst
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(0) | ||
|
|
||
| def tzname(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: tzname. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function tzname
Please provide type hint for the parameter: dt
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class CustomTimeZone(datetime.tzinfo): | ||
| def utcoffset(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: utcoffset. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function utcoffset
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(hours=1) | ||
|
|
||
| def dst(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: dst. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function dst
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(0) | ||
|
|
||
| def tzname(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: tzname. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function tzname
Please provide type hint for the parameter: dt
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class CustomTimeZone(datetime.tzinfo): | ||
| def utcoffset(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: utcoffset. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function utcoffset
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(hours=0) | ||
|
|
||
| def dst(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: dst. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function dst
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(0) | ||
|
|
||
| def tzname(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: tzname. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function tzname
Please provide type hint for the parameter: dt
| return "Custom Time Zone" | ||
|
|
||
|
|
||
| def get_current_time_in_casablanca(): |
There was a problem hiding this comment.
Please provide return type hint for the function: get_current_time_in_casablanca. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function get_current_time_in_casablanca
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class CustomTimeZone(datetime.tzinfo): | ||
| def utcoffset(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: utcoffset. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function utcoffset
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(hours=0) | ||
|
|
||
| def dst(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: dst. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function dst
Please provide type hint for the parameter: dt
| print(dt) | ||
| return datetime.timedelta(0) | ||
|
|
||
| def tzname(self, dt): |
There was a problem hiding this comment.
Please provide return type hint for the function: tzname. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function tzname
Please provide type hint for the parameter: dt
| return "Custom Time Zone" | ||
|
|
||
|
|
||
| def get_current_time_in_casablanca(): |
There was a problem hiding this comment.
Please provide return type hint for the function: get_current_time_in_casablanca. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/wildcard_matching.py, please provide doctest for the function get_current_time_in_casablanca
algorithms-keeper
bot
removed
require tests
|
The "Wildcard Matching" problem offers several advantages. Firstly, it promotes the development of algorithmic skills, enhancing one's ability to handle string manipulation and efficiently manage patterns containing wildcard characters. Secondly, it aids in comprehending and effectively handling commonly used wildcard patterns like '*' and '?,' which find utility in various applications, including regular expressions. Additionally, as a challenging problem categorized as hard, it serves as an intellectual exercise, fostering logical thinking and creativity. Furthermore, its practical relevance in text processing, information retrieval, and file searching underscores its significance in real-world scenarios, making it a valuable problem-solving endeavor. |
|
Im add doctest |
algorithms-keeper
bot
added
the
merge conflicts
algorithms-keeper
bot
removed
the
merge conflicts
algorithms-keeper
bot
removed
the
awaiting reviews
* add new programme in dynamique programming wildcard_matching * add new programme in dynamique programming wildcard_matching * fix bug * fix * fix * fix * fix * fix * fix error recrusion * fix error recrusion * bug fix * add doctest * The power of enumerate() --------- Co-authored-by: Christian Clauss <cclauss@me.com>
Describe your change:
Checklist: