Skip to content

Conversation

hollowcrust
Copy link
Contributor

@hollowcrust hollowcrust commented Oct 8, 2023

Describe your change:

Fixes #8098.

Deleted longest_sub_array.py since longest_sub_array.py solves a similar problem with max_subarray_sum.py (maximum sum of a subarray), but it has no doctests and not as completed as the latter.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@hollowcrust
Copy link
Contributor Author

@tianyizheng02 Hi can you help me review this, please? Thanks.

@hollowcrust
Copy link
Contributor Author

@tianyizheng02 Hi can you help me review this, please? Thanks.

@tianyizheng02 tianyizheng02 merged commit e9b3f20 into TheAlgorithms:master Oct 16, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2023
@hollowcrust hollowcrust deleted the patch-del branch October 16, 2023 08:47
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
@LohitMoharana
Copy link

“Hi, I’m comfortable with Python and ML. I’d like to work on adding unit tests to one of the algorithms.”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concatenate/consolidate all algorithms with different implementations

3 participants