Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add : Best time to buy and sell stock program under GREEDY methods #10114

Merged
merged 3 commits into from
Oct 8, 2023
Merged

add : Best time to buy and sell stock program under GREEDY methods #10114

merged 3 commits into from
Oct 8, 2023

Conversation

kosuri-indu
Copy link
Contributor

Describe your change:

This PR is to add the Best time to buy and sell stock program under greedy methods.
Fixes #10113

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2023
@kosuri-indu kosuri-indu changed the title add : to add Best time to buy and sell stock program under GREEDY methods add : Best time to buy and sell stock program under GREEDY methods Oct 8, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 8, 2023
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 8, 2023
Closed
14 tasks
@kosuri-indu
Copy link
Contributor Author

Hey @cclauss , Could you review this pull request and suggest any changes ?

@cclauss cclauss enabled auto-merge (squash) October 8, 2023 17:06
@kosuri-indu
Copy link
Contributor Author

@cclauss Thank you for updating :) !

@cclauss cclauss merged commit 982bc27 into TheAlgorithms:master Oct 8, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 8, 2023
@cclauss
Copy link
Member

cclauss commented Oct 8, 2023 •
edited
Loading

Buying and selling stocks is trivial when you have all the quotes and then can go back in time and buy and sell.

Like shooting fish in a barrel 🐟

@kosuri-indu
Copy link
Contributor Author

kosuri-indu commented Oct 8, 2023 •
edited
Loading

Buying and selling stocks is trivial when you have all the quotes and then can go back in time and buy and sell.

Like shooting fish in a barrel 🐟

That is true hehe

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@kosuri-indu @pre-commit-ci
@cclauss @sedatguzelsemme
add : Best time to buy and sell stock program under GREEDY methods (T…
fa7867a 
…heAlgorithms#10114)

* to add best_time_stock program

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update best_time_to_buy_and_sell_stock.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] : Best time to buy and sell stock program by using GREEDY
2 participants
@kosuri-indu @cclauss