Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Germain primes algorithm to the maths folder #10120

Merged
merged 10 commits into from
Oct 8, 2023
Merged

Added Germain primes algorithm to the maths folder #10120

merged 10 commits into from
Oct 8, 2023

Conversation

megpay
Copy link
Contributor

@megpay megpay commented Oct 8, 2023

Describe your change:

  • [X ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 8, 2023
megpay
megpay commented Oct 8, 2023
View reviewed changes
Copy link
Contributor Author

@megpay megpay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the path to the import

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 8, 2023
tianyizheng02
tianyizheng02 requested changes Oct 8, 2023
View reviewed changes
megpay and others added 5 commits October 8, 2023 20:15
@megpay @tianyizheng02
Update maths/germain_primes.py
b01463c 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@megpay @tianyizheng02
Update maths/germain_primes.py
eb6a6fd 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@megpay
Merge branch 'TheAlgorithms:master' into master
88583ec
@meganpayneconsulting
Added function for safe primes
a082e47
@megpay @tianyizheng02
Update maths/germain_primes.py
7c7d824 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@megpay megpay requested a review from tianyizheng02 October 8, 2023 21:16
tianyizheng02
tianyizheng02 requested changes Oct 8, 2023
View reviewed changes
@tianyizheng02 tianyizheng02 merged commit a2b695d into TheAlgorithms:master Oct 8, 2023
@tianyizheng02
Copy link
Contributor

Thanks for your contribution!

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@megpay @meganpayneconsulting
@tianyizheng02 @sedatguzelsemme
Added Germain primes algorithm to the maths folder (TheAlgorithms#10120)
4917341 
* Added algorithm for Germain Primes to maths folder

* Fixed test errors Germain primes.

* Formatting Germain primes after pre-commit

* Fixed path to maths

* Update maths/germain_primes.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Update maths/germain_primes.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Added function for safe primes

* Update maths/germain_primes.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Apply suggestions from code review

---------

Co-authored-by: Megan Payne <payneconsulting.nl@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megpay @tianyizheng02 @meganpayneconsulting