Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #9943 Added Doctests to binary_exponentiation_3.py #10121

Merged
merged 32 commits into from
Oct 10, 2023
Merged

Fixes #9943 Added Doctests to binary_exponentiation_3.py #10121

merged 32 commits into from
Oct 10, 2023

Conversation

vipinkarthic
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

vipinkarthic and others added 27 commits October 4, 2023 20:47
@vipinkarthic
Python mirror_formulae.py is added to the repository
3abb0b4
@vipinkarthic
Changes done after reading readme.md
bc1942a
@vipinkarthic
Merge branch 'TheAlgorithms:master' into master
acc30f0
@vipinkarthic
Merge branch 'TheAlgorithms:master' into master
def94b6
@vipinkarthic
Changes for running doctest on all platforms
d0979d3
@vipinkarthic
Merge branch 'master' of https://github.com/vipinkarthic/Python
22f8647
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e5f2d76 
for more information, see https://pre-commit.ci
@vipinkarthic
Change 2 for Doctests
0ed896b
@vipinkarthic
Merge branch 'TheAlgorithms:master' into master
987068a
@vipinkarthic
Merge branch 'master' of https://github.com/vipinkarthic/Python
87cc27c
@vipinkarthic
Merge branch 'master' of https://github.com/vipinkarthic/Python
94b630c
@vipinkarthic
Changes for doctest 2
8affc05
updating DIRECTORY.md
e250ede
@vipinkarthic
Doctest whitespace error rectification to mirror_formulae.py
c79e132
@vipinkarthic
Merge branch 'master' of https://github.com/vipinkarthic/Python
66fa39b
@cclauss
Merge branch 'master' into master
c04420d
updating DIRECTORY.md
5355c97
@vipinkarthic
Adding Thermodynamic Work Done Formulae
a749a2b
@vipinkarthic
Merge branch 'master' of https://github.com/vipinkarthic/Python
2537ea6
@vipinkarthic
Work done on/by body in a thermodynamic setting
6c7765c
@vipinkarthic
Merge branch 'master' of https://github.com/vipinkarthic/Python
a7561bc
updating DIRECTORY.md
96ed5c1
@vipinkarthic
Merge branch 'TheAlgorithms:master' into main
e6cc31c
updating DIRECTORY.md
873fe87
@vipinkarthic
Doctest adiition to binary_exponentiation_3.py
489b890
@vipinkarthic
Change 1
0be0051
updating DIRECTORY.md
b71c1b9
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 8, 2023
@vipinkarthic vipinkarthic changed the title Added Doctests to binary_exponentiation_3.py Fixes #9943 Added Doctests to binary_exponentiation_3.py Oct 9, 2023
@vipinkarthic
Copy link
Contributor Author

@tianyizheng02 , Is the number of commits the PR shows is fine? It is showing all the commits of the previous PR as well as the commits for the current PR. Thanks in advance for taking a look into my doubt and PR

@tianyizheng02
Copy link
Contributor

The number of commits doesn;'t matter. In this repo, we use "squash and merge", which means that all the commits for a single PR are combined into a single commit when the PR is merged.

@tianyizheng02
Copy link
Contributor

Also, we can't merge this because there are merge conflicts. I renamed binary_exponentiation_3.py to binary_exponentiation_2.py in a previous PR (#9656), so you should rename the file here as well in order to resolve the conflict.

@vipinkarthic
Copy link
Contributor Author

The number of commits doesn;'t matter. In this repo, we use "squash and merge", which means that all the commits for a single PR are combined into a single commit when the PR is merged.

Also, if a PR is already open and not merged yet, should I wait till it's merged to create a new PR for another issue?

@vipinkarthic vipinkarthic reopened this Oct 9, 2023
@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 9, 2023
@vipinkarthic
Copy link
Contributor Author

vipinkarthic commented Oct 9, 2023 •
edited
Loading

Also, we can't merge this because there are merge conflicts. I renamed binary_exponentiation_3.py to binary_exponentiation_2.py in a previous PR (#9656), so you should rename the file here as well in order to resolve the conflict.

I have renamed the file, but it still says there is some error, can you help me with it , Thank You !
I ran the pre commit test in my local machine and all the results were true, I've attached the photos below:

@tianyizheng02

image

image

@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 10, 2023
@tianyizheng02 tianyizheng02 merged commit 6d13603 into TheAlgorithms:master Oct 10, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 10, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@vipinkarthic @pre-commit-ci
@cclauss @tianyizheng02 @sedatguzelsemme
Fixes TheAlgorithms#9943 Added Doctests to binary_exponentiation_3.py (…
155bd0b 
…TheAlgorithms#10121)

* Python mirror_formulae.py is added to the repository

* Changes done after reading readme.md

* Changes for running doctest on all platforms

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change 2 for Doctests

* Changes for doctest 2

* updating DIRECTORY.md

* Doctest whitespace error rectification to mirror_formulae.py

* updating DIRECTORY.md

* Adding Thermodynamic Work Done Formulae

* Work done on/by body in a thermodynamic setting

* updating DIRECTORY.md

* updating DIRECTORY.md

* Doctest adiition to binary_exponentiation_3.py

* Change 1

* updating DIRECTORY.md

* Rename binary_exponentiation_3.py to binary_exponentiation_2.py

* updating DIRECTORY.md

* updating DIRECTORY.md

* Formatting

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vipinkarthic @tianyizheng02 @cclauss