Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added categorical_crossentropy loss function #10152

Merged
merged 14 commits into from
Oct 10, 2023
Merged

Added categorical_crossentropy loss function #10152

merged 14 commits into from
Oct 10, 2023

Conversation

THEGAMECHANGER416
Copy link
Contributor

Describe your change:

Added categorical_cross_entropy.py in machine_learning/loss_functions

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 9, 2023
@THEGAMECHANGER416
Copy link
Contributor Author

@tianyizheng02 Added CategoricalCrossEntropy in loss_functions
Passes all the tests and all the previous reuested changes
Hope it passes all necessary reviews
Thanks

@THEGAMECHANGER416 @tianyizheng02
Update machine_learning/loss_functions/categorical_cross_entropy.py
341df18 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 9, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 9, 2023
THEGAMECHANGER416 and others added 2 commits October 10, 2023 12:13
@THEGAMECHANGER416 @tianyizheng02
Update machine_learning/loss_functions/categorical_cross_entropy.py
eeb0bc6 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@THEGAMECHANGER416 @tianyizheng02
Update machine_learning/loss_functions/categorical_cross_entropy.py
c60aad4 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 10, 2023
@tianyizheng02
Copy link
Contributor

Sorry, I see the problem: I'll adjust the one-hot encoding check to support multi-row arrays

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 10, 2023
@THEGAMECHANGER416
Copy link
Contributor Author

THEGAMECHANGER416 commented Oct 10, 2023 •
edited
Loading

@tianyizheng02 Done! Let me know if it needs any other changes
Thanks

tianyizheng02
tianyizheng02 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and for your fixes!

@tianyizheng02 tianyizheng02 merged commit 59fc0ce into TheAlgorithms:master Oct 10, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 10, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@THEGAMECHANGER416 @sedatguzelsemme
Added categorical_crossentropy loss function (TheAlgorithms#10152)
efc37fd
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@THEGAMECHANGER416 @tianyizheng02