Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctests to carmichael_number.py #10210

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add doctests to carmichael_number.py #10210

merged 2 commits into from
Oct 11, 2023

Conversation

vipinkarthic
Copy link
Contributor

@vipinkarthic vipinkarthic commented Oct 10, 2023 •
edited by cclauss
Loading

Describe your change:

Related to

Added Doctests to Carmichael_number.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@vipinkarthic
Copy link
Contributor Author

@cclauss

Can you take a look at the PR and let me know if I should add more doctests or if this is fine?

@cclauss cclauss changed the title Fixes #9943 Added Doctests to carmichael_number.py Add doctests to carmichael_number.py Oct 11, 2023
@cclauss
Copy link
Member

cclauss commented Oct 11, 2023

Git conflicts.

@vipinkarthic
Copy link
Contributor Author

Git conflicts.

Someone has modified the current while i was modifying this, so thank you for your time, I'll ping you after I find another doctest missing file and create another PR for that. Thank You !

Please close the PR.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@tianyizheng02
Copy link
Contributor

@vipinkarthic I fixed the merge conflict by adding your doctests to the existing ones.

@tianyizheng02 tianyizheng02 merged commit 92fbe60 into TheAlgorithms:master Oct 11, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@vipinkarthic @tianyizheng02 @sedatguzelsemme
Added doctests to carmichael_number.py (TheAlgorithms#10210)
2f0ef94 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vipinkarthic @cclauss @tianyizheng02