Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the algorithm to compute the terminal velocity of an object fal… #10237

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

pluto-tofu
Copy link
Contributor

…ling in a fluid

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 10, 2023
@pluto-tofu
Copy link
Contributor Author

Could someone please review this pull request.

raise ValueError(
"mass, density, area and the drag coefficient all need to be positive"
)
return ((2 * mass * 9.8) / (density * area * drag_coefficient)) ** 0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a hard-coded 9.8 for the acceleration due to gravity, could you import the constant from scipy.constants? The constant value in this library is more accurate.

https://docs.scipy.org/doc/scipy/reference/constants.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure , I'll import the value of g and commit the changes

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 23, 2023
@tianyizheng02 tianyizheng02 merged commit abc3909 into TheAlgorithms:master Oct 23, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2023
@tianyizheng02
Copy link
Contributor

Thanks for your contribution!

@pluto-tofu pluto-tofu deleted the terminal_velocity branch October 23, 2023 05:52
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
TheAlgorithms#10237)

* added the algorithm to compute the terminal velocity of an object falling in a fluid

* fixed spelling mistake

* fixed issues in topic description

* imported the value of g from scipy and changed the doctests accordingly

* fixed formatting

* Apply suggestions from code review

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants