Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the algorithm to compute the time period of a simple pendulum #10265

Merged
merged 6 commits into from
Dec 31, 2024
Merged

Added the algorithm to compute the time period of a simple pendulum #10265

merged 6 commits into from
Dec 31, 2024

Conversation

pluto-tofu
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@pluto-tofu pluto-tofu force-pushed the time_period_simple_pendulum branch from 1b1b983 to d38f52c Compare October 23, 2023 05:55
@pluto-tofu
Copy link
Contributor Author

@tianyizheng02 Could you please take a look at this pull request, I will make any necessary changes that you suggest.

tianyizheng02
tianyizheng02 requested changes Oct 26, 2023
View reviewed changes
physics/time_period_simple_pendulum.py Outdated Show resolved Hide resolved
physics/time_period_simple_pendulum.py Outdated Show resolved Hide resolved
physics/time_period_simple_pendulum.py Outdated Show resolved Hide resolved
@pluto-tofu pluto-tofu force-pushed the time_period_simple_pendulum branch from 26df1fc to 66a8f93 Compare October 28, 2023 06:02
@pluto-tofu
Copy link
Contributor Author

@tianyizheng02 Sorry, I was a little late in making the requested changes but I committed the changes yesterday and it's showing outdated as of now. Could you please look into it.

tianyizheng02
tianyizheng02 approved these changes Dec 31, 2024
View reviewed changes
physics/period_of_pendulum.py Outdated Show resolved Hide resolved
@tianyizheng02 tianyizheng02 merged commit 8439fa8 into TheAlgorithms:master Dec 31, 2024
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pluto-tofu @tianyizheng02