Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding doctests in simpson_rule.py #10269

Merged
merged 23 commits into from
Oct 11, 2023
Merged

Adding doctests in simpson_rule.py #10269

merged 23 commits into from
Oct 11, 2023

Conversation

AasheeshLikePanner
Copy link
Contributor

@AasheeshLikePanner AasheeshLikePanner commented Oct 11, 2023 •
edited
Loading

Describe your change:

Adding doctests in simpson_rule.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
    Improve our test coverage #9943

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 11, 2023
@AasheeshLikePanner AasheeshLikePanner mentioned this pull request Oct 11, 2023
Open
cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
AasheeshLikePanner and others added 2 commits October 11, 2023 16:59
@AasheeshLikePanner @cclauss
Update maths/simpson_rule.py
7c4e6c7 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AasheeshLikePanner @cclauss
Update maths/simpson_rule.py
3412f56 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 11, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 11, 2023
@AasheeshLikePanner
Copy link
Contributor Author

AasheeshLikePanner commented Oct 11, 2023 •
edited
Loading

@cclauss Can you check now.

cclauss
cclauss requested changes Oct 11, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 11, 2023
@AasheeshLikePanner
Merge remote-tracking branch 'origin/simpson_rule_doctests' into simp…
39fa849 
…son_rule_doctests

# Conflicts:
#	maths/simpson_rule.py
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 11, 2023
@AasheeshLikePanner
Copy link
Contributor Author

@cclauss Can you check now.

cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
@cclauss cclauss enabled auto-merge (squash) October 11, 2023 17:58
auto-merge was automatically disabled October 11, 2023 18:00

Head branch was pushed to by a user without write access

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
@cclauss cclauss enabled auto-merge (squash) October 11, 2023 18:19
@cclauss cclauss disabled auto-merge October 11, 2023 18:19
cclauss
cclauss approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@cclauss cclauss merged commit d5323db into TheAlgorithms:master Oct 11, 2023
@AasheeshLikePanner
Copy link
Contributor Author

Thank you for helping me to understand how to handle errors in doctests. A great learning today.
Thank you.

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@AasheeshLikePanner @pre-commit-ci
@cclauss @sedatguzelsemme
Adding doctests in simpson_rule.py (TheAlgorithms#10269)
edfc889 
* Adding doctests in simpson_rule.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update maths/simpson_rule.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update maths/simpson_rule.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Adding doctests in simpson_rule.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding doctests in simpson_rule.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding doctests in simpson_rule.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding doctests in simpson_rule.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Adding doctests in simpson_rule.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update simpson_rule.py

* Adding doctests in simpson_rule.py

* Adding doctests in simpson_rule.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AasheeshLikePanner @cclauss