Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solovay-Strassen Primality test #10335

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Add Solovay-Strassen Primality test #10335

merged 3 commits into from
Oct 13, 2023

Conversation

saahil-mahato
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@cclauss
Copy link
Member

cclauss commented Oct 12, 2023

#6228 @tianyizheng02 @ChrisO345 Do we need more ways to test for prime numbers?

tianyizheng02
tianyizheng02 previously requested changes Oct 13, 2023
View reviewed changes
@tianyizheng02
Copy link
Contributor

Do we need more ways to test for prime numbers?

@cclauss I think it's fine to add this. The Solovay–Strassen primality test is a specific, distinct algorithm for testing whether a number is (probably) prime, and it's an algorithm we don't have yet. I'd say having it for educational purposes is enough justification.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 13, 2023
cclauss
cclauss requested changes Oct 13, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 13, 2023
@cclauss cclauss enabled auto-merge (squash) October 13, 2023 06:02
@cclauss cclauss merged commit ebe6693 into TheAlgorithms:master Oct 13, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@saahil-mahato @sedatguzelsemme
Add Solovay-Strassen Primality test (TheAlgorithms#10335)
d77d0ed 
* Add Solovay-Strassen Primality test

* fix: resolve comments

* refactor: docs change
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@tianyizheng02 tianyizheng02 Awaiting requested review from tianyizheng02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saahil-mahato @cclauss @tianyizheng02