Edit_Distance algorithm for genetic string matching #10336
Conversation
algorithms-keeper
bot
added
tests are failing
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Assumptions: | ||
| The cost of operations (insertion, deletion and subtraction) is all 1 | ||
| """ | ||
| delta = {True: 0, False: 1} # Substitution |
There was a problem hiding this comment.
An error occurred while parsing the file: genetic_algorithm/edit_distance.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 19:4.
parser error: error at 18:3: expected INDENT
delta = {True: 0, False: 1} # Substitution
^
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
added
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
genetic_algorithm/edit_distance.py
Outdated
| @@ -0,0 +1,34 @@ | |||
| def edit_distance(source, target): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: edit_distance. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/edit_distance.py, please provide doctest for the function edit_distance
Please provide type hint for the parameter: source
Please provide type hint for the parameter: target
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
genetic_algorithm/edit_distance.py
Outdated
| @@ -0,0 +1,34 @@ | |||
| def edit_distance(source, target): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: edit_distance. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/edit_distance.py, please provide doctest for the function edit_distance
Please provide type hint for the parameter: source
Please provide type hint for the parameter: target
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
genetic_algorithm/edit_distance.py
Outdated
| @@ -0,0 +1,42 @@ | |||
| def edit_distance(source, target): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: edit_distance. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: source
Please provide type hint for the parameter: target
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,42 @@ | |||
| def edit_distance(source: str, target: str): -> int | |||
| """ | |||
There was a problem hiding this comment.
An error occurred while parsing the file: genetic_algorithm/edit_distance.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 2:8.
parser error: error at 1:48: expected one of (, *, +, -, ..., AWAIT, False, NAME, NEWLINE, NUMBER, None, True, [, break, continue, lambda, not, pass, ~
"""
^
algorithms-keeper
bot
removed
the
tests are failing
|
You checked this checkbox, so you acknowledged this:
|
|
My mistake, I had forgotten that we had a separate directory for genetic algorithms. However, edit distance is still definitely not a genetic algorithm. We also already have multiple implementations of edit distance (using dynamic programming). Since your implementation doesn't use DP, you're welcome to add it to one of the existing files instead of creating a separate file. |
|
I added it to the genetic algorithms considering that edit distance would be used for genome matching scenarios. |
|
Superseded by #10571 |
Describe your change:
Checklist: