Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug/update program to get desigred output #10366

Conversation

vishalgupta2k
Copy link

Describe your change:

The change was in the program to get the desigred output

Fixes #10357

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Oct 13, 2023
@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Oct 14, 2023

  1. Please do not modify multiple algorithms. Make separate PRs for your docker documentation contributions and for your other contributions.
  2. Your changes to missing_number.py entirely changes the algorithm. The whole purpose of the problem is to use bit manipulation to find the missing number—without simply searching for the number. Furthermore, your solution breaks if the list is not in order. Ultimately it doesn't solve the issue you link.

@tianyizheng02 tianyizheng02 added the multiple algorithms not allowed Multiple algorithms in a single PR are not allowed label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files multiple algorithms not allowed Multiple algorithms in a single PR are not allowed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing_number algorithm dosen't work as intended (bit_manipulation/missing_number.py)
2 participants