Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate_solutions.py: os.getenv('GITHUB_TOKEN', '') #10546

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2023

@tianyizheng02

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the enhancement This PR modified some existing files label Oct 15, 2023
@cclauss cclauss requested a review from tianyizheng02 October 15, 2023 16:40
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 15, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
@tianyizheng02 tianyizheng02 merged commit 68e6d5a into master Oct 15, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@tianyizheng02 tianyizheng02 deleted the Fix-validate_solutions branch October 15, 2023 17:11
@tianyizheng02
Copy link
Contributor

@cclauss From the most recent build in #10542:

    if filepaths := added_solution_file_path():
scripts/validate_solutions.py:62: in added_solution_file_path
    filepath = pathlib.Path.cwd().joinpath(file["filename"])
E   TypeError: string indices must be integers, not 'str'
        file       = 'message'
        files      = {'documentation_url': 'https://docs.github.com/rest', 'message': 'Bad credentials'}
        headers    = {'Accept': 'application/vnd.github.v3+json', 'Authorization': 'token '}
        solution_file_paths = []
...
=========================== short test summary info ============================
ERROR scripts/validate_solutions.py - TypeError: string indices must be integers, not 'str'
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
========================= 1 warning, 1 error in 18.09s =========================
Error: Process completed with exit code 2.

@cclauss cclauss restored the Fix-validate_solutions branch October 15, 2023 19:31
cclauss added a commit that referenced this pull request Oct 15, 2023
tianyizheng02 pushed a commit that referenced this pull request Oct 15, 2023
* Revert "validate_solutions.py: os.getenv('GITHUB_TOKEN', '') (#10546)"

This reverts commit 68e6d5a.

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@cclauss cclauss deleted the Fix-validate_solutions branch October 15, 2023 19:54
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
…0546)

* validate_solutions.py: os.getenv('GITHUB_TOKEN', '')

@tianyizheng02

* updating DIRECTORY.md

* f this

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
…orithms#10552)

* Revert "validate_solutions.py: os.getenv('GITHUB_TOKEN', '') (TheAlgorithms#10546)"

This reverts commit 68e6d5a.

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants