Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic programming/matrix chain multiplication #10549

Conversation

Shailaputri
Copy link
Contributor

@Shailaputri Shailaputri commented Oct 15, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

P.s. I would like to add that I started by trying to add doctests to matrix_chain_order.py script under Python/dynamic_programming/matrix_chain_order in order to improve its test coverage. However, I found the functions poorly written. Instead of changing the code, I have written a separate script with bug free code, problem explanation and required doctests. Moderators may consider deleting matrix_chain_order.py.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss
Copy link
Member

cclauss commented Oct 15, 2023

When would the algorithm be used in the real-world?

codespell

dynamic_programming/matrix_chain_multiplication.py:11: dimesions ==> dimensions

mypy

dynamic_programming/matrix_chain_multiplication.py:72: error: Incompatible return value type (got "float", expected "int") [return-value]

@Shailaputri
Copy link
Contributor Author

New PR #10562 added with all corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants