-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD]: Improved tests in power recursion! #10664
Conversation
@tianyizheng02 can you have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull requests should either add/improve tests or should change the code. This PR changes both the tests and the code. This makes the PR much more difficult to review.
Please revert the change to the algorithm and the change of the filename. Let's have this pull request JUST focus on improving the testing.
@tianyizheng02 Perhaps we need to talk more in CONTRIBUTING.md about not changing both code and tests in a single PR.
@cclauss can you check the change, cause I've made the as per your choice. |
@cclauss can you please add #hacktoberfest-accepted label. |
* Added new tests! * [ADD]: Inproved Tests * fixed * Removed spaces * Changed the file name * Added Changes * changed the code and kept the test cases * changed the code and kept the test cases * missed the line * removed spaces * Update power_using_recursion.py --------- Co-authored-by: Christian Clauss <cclauss@me.com>
Describe your change:
[ADD]: New test cases for all_combinations !
Checklist: