Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff error in machine_learning/sequential_minimum_optimization.py #10717

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Fix ruff error in machine_learning/sequential_minimum_optimization.py #10717

merged 5 commits into from
Oct 20, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

All ruff workflows are currently failing due to an error in machine_learning/sequential_minimum_optimization.py (e.g., my comment in #10714)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@tianyizheng02 tianyizheng02 marked this pull request as ready for review October 20, 2023 02:24
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 20, 2023
@tianyizheng02 tianyizheng02 requested a review from cclauss October 20, 2023 02:25
@PoojanSmart PoojanSmart mentioned this pull request Oct 20, 2023
Closed
15 tasks
@RaymondDashWu RaymondDashWu mentioned this pull request Oct 20, 2023
Merged
15 tasks
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 20, 2023
@cclauss cclauss merged commit 5180533 into master Oct 20, 2023
@cclauss cclauss deleted the fix-ruff-seq-min-opt branch October 20, 2023 03:35
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Fix ruff error in `machine_learning/sequential_minimum_optimization.p…
d496225 
…y` (TheAlgorithms#10717)

* updating DIRECTORY.md

* Try to fix ruff error in sequential_minimum_optimization.py

* Update sequential_minimum_optimization.py

* Update sequential_minimum_optimization.py

* Update sequential_minimum_optimization.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianyizheng02 @cclauss