-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Added New Tests in Signum #10724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New Tests in Signum #10724
Conversation
Please do NOT remove tests. The original developer might have had very good reasons for creating those particular tests. Also, please run
Finally, please try to add tests that show how the algorithm fails with difficult or garbage input.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bring back the old tests and add more.
Does it meet the requirements or can you tell me I'll add more tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more
Co-authored-by: Christian Clauss <cclauss@me.com>
|
Test cases have passed |
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss Thanks a lot for mentoring me |
The trick is NOT to change the code to fix the test but to change ONLY the test to describe how the code ACTUALLY works. |
* Added new tests! * [ADD]: Inproved Tests * fixed * Removed spaces * Changed the file name * Added Changes * changed the code and kept the test cases * changed the code and kept the test cases * missed the line * removed spaces * Update power_using_recursion.py * Added new tests in Signum * Few things added * Removed few stuff and added few changes * Fixed few things * Reverted the function * Update maths/signum.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added few things * Update maths/signum.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added the type hint back * Update signum.py --------- Co-authored-by: Christian Clauss <cclauss@me.com>
Describe your change:
Added new tests in Signum
Checklist: