-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RGB to CMYK color converter #10741
feat: RGB to CMYK color converter #10741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
conversions/rgb_cmyk_conversion.py
Outdated
@@ -0,0 +1,71 @@ | |||
def rgb_to_cmyk(r_input, g_input, b_input: int) -> tuple[int, int, int, int]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide type hint for the parameter: r_input
Please provide type hint for the parameter: g_input
Thanks for your contribution! |
Thank you :) |
* feat: code functional, commented, tested * fix: compering types, exception msg, line length * fix: type hints
Popular RGB to CMYK conversion algorithm. Accepts RGB values, returns percentages of CMYK paint.
Direct PR, no Issue created.
Checklist: