Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code enhancement in sort.double_sort #10798

Merged
merged 9 commits into from
Oct 23, 2023
Merged

code enhancement in sort.double_sort #10798

merged 9 commits into from
Oct 23, 2023

Conversation

Krishna-Singhal
Copy link
Contributor

@Krishna-Singhal Krishna-Singhal commented Oct 22, 2023 •
edited
Loading

Describe your change:

  • Don't need to return list because list is mutable
  • use advantage of python in swapping
  • filter blank inputs from input list
  • minor changes
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@Krishna-Singhal
don't need to return list because list is mutable
81673c7 
* Don't need to return list as list is mutable
* use advantage of python in swapping
* filter blank inputs from input list
* minor changes
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 22, 2023
@Krishna-Singhal
Copy link
Contributor Author

It would help me if you could add label hacktoberfest-accepted, Thanks...

@cclauss
Copy link
Member

cclauss commented Oct 22, 2023 •
edited
Loading

Let's change line 1 to a commitment to return a tuple:

def double_sort(unsorted: list) -> tuple:

Let's change the vague name lst to unsorted which is more self-documenting.

@cclauss
Copy link
Member

cclauss commented Oct 22, 2023 •
edited
Loading

No label until the tests pass and it is merged. ;-)

As discussed in CONTRIBUTING.md, you can run the build tests on your computer with the command:

python3 -m doctest -v sorts/double_sort.py

@cclauss cclauss self-assigned this Oct 22, 2023
@Krishna-Singhal
Copy link
Contributor Author

As discussed in CONTRIBUTING.md, you can run the build tests on your computer with the command:

python3 -m doctest -v sorts/double_sort.py

All tests are passed on my computer.

@cclauss
Copy link
Member

cclauss commented Oct 22, 2023

The functions returns None so the failure on line 807 makes sense to me.
https://github.com/TheAlgorithms/Python/actions/runs/6602527016/job/17934662337?pr=10801#step:6:808

@Krishna-Singhal Krishna-Singhal changed the title Don't need to return list because list is mutable code enhancement in sort.double_sort Oct 22, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 22, 2023
@Krishna-Singhal
Copy link
Contributor Author

Krishna-Singhal commented Oct 23, 2023 •
edited
Loading

The functions returns None so the failure on line 807 makes sense to me. https://github.com/TheAlgorithms/Python/actions/runs/6602527016/job/17934662337?pr=10801#step:6:808

@cclauss, could you review now please?

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
cclauss
cclauss approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thanks for doing this.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2023
@cclauss cclauss merged commit 417b7ed into TheAlgorithms:master Oct 23, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Krishna-Singhal @pre-commit-ci
@cclauss @sedatguzelsemme
code enhancement in sort.double_sort (TheAlgorithms#10798)
4ab8267 
* don't need to return list because list is mutable

* Don't need to return list as list is mutable
* use advantage of python in swapping
* filter blank inputs from input list
* minor changes

* minor mistake

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more readable

* Update double_sort.py

* last fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krishna-Singhal @cclauss