Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete arithmetic_analysis/ directory and relocate its contents #10824

Merged

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 23, 2023

Describe your change:

Fixes #8863

Deleted the arithmetic_analysis/ directory and relocated its files because the purpose of the directory was always ill-defined. "Arithmetic analysis" isn't a known field of math, and the directory's files contained algorithms for linear algebra, numerical analysis, and even physics.

Relocated the directory's linear algebra algorithms to linear_algebra/, its numerical analysis algorithms to a new subdirectory called maths/numerical_analysis/, and its single physics algorithm to physics/. Doing this revealed multiple duplicate algorithms that will need to be consolidated/deleted in future PRs.

Incidentally, I also had to fix #8863 in this PR by removing all instances of eval from arithmetic_analysis/newton_raphson.py because ruff wouldn't let me commit my changes otherwise.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

tianyizheng02 and others added 3 commits October 22, 2023 20:47
Delete the arithmetic_analysis/ directory and relocate its files because
the purpose of the directory was always ill-defined. "Arithmetic
analysis" isn't a field of math, and the directory's files contained
algorithms for linear algebra, numerical analysis, and physics.

Relocated the directory's linear algebra algorithms to linear_algebra/,
its numerical analysis algorithms to a new subdirectory called
maths/numerical_analysis/, and its single physics algorithm to physics/.
@tianyizheng02 tianyizheng02 requested a review from cclauss October 23, 2023 01:01
@tianyizheng02 tianyizheng02 changed the title Relocate arithmetic analysis Delete arithmetic_analysis/ directory and relocate its contents Oct 23, 2023
@cclauss cclauss enabled auto-merge (squash) October 23, 2023 07:31
@cclauss cclauss merged commit a8b6bda into TheAlgorithms:master Oct 23, 2023
@tianyizheng02 tianyizheng02 deleted the relocate-arithmetic-analysis branch October 23, 2023 07:39
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
…eAlgorithms#10824)

* Remove eval from arithmetic_analysis/newton_raphson.py

* Relocate contents of arithmetic_analysis/

Delete the arithmetic_analysis/ directory and relocate its files because
the purpose of the directory was always ill-defined. "Arithmetic
analysis" isn't a field of math, and the directory's files contained
algorithms for linear algebra, numerical analysis, and physics.

Relocated the directory's linear algebra algorithms to linear_algebra/,
its numerical analysis algorithms to a new subdirectory called
maths/numerical_analysis/, and its single physics algorithm to physics/.

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor arithmetic_analysis/newton_raphson to not use eval
2 participants