Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance readability of Minimax #10838

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Enhance readability of Minimax #10838

merged 8 commits into from
Oct 23, 2023

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 23, 2023

Added function docstring and comments explaining the base case, maximizer and minimizer turns.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 23, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Oct 23, 2023
tianyizheng02
tianyizheng02 requested changes Oct 23, 2023
View reviewed changes
Hardvan and others added 3 commits October 23, 2023 19:23
@Hardvan @tianyizheng02
Update backtracking/minimax.py
e0282c9 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@Hardvan @tianyizheng02
Update backtracking/minimax.py
36ca2c9 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@Hardvan @tianyizheng02
Update backtracking/minimax.py
9474d75 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@Hardvan Hardvan requested a review from tianyizheng02 October 23, 2023 13:54
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 23, 2023
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 23, 2023

I have committed the requested changes.

@tianyizheng02 tianyizheng02 merged commit 54e2aa6 into TheAlgorithms:master Oct 23, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Hardvan @pre-commit-ci
@tianyizheng02 @sedatguzelsemme
Enhance readability of Minimax (TheAlgorithms#10838)
3fa37e7 
* Enhance readability of Minimax

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Reduce line overflow

* Update backtracking/minimax.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Update backtracking/minimax.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Update backtracking/minimax.py

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

* Remove line overflow

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hardvan @tianyizheng02