Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctests for fractional knapsack #10891

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 24, 2023

Added doctests for the Fractional Knapsack algorithm, as requested in PR #10888

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 24, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2023
@cclauss cclauss self-assigned this Oct 24, 2023
@cclauss
Copy link
Member

cclauss commented Oct 24, 2023

On your computer do python3 -m doctest -v filename.py to run the tests.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2023
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 24, 2023

I have successfully executed the doctests, yielding the following output:

11 tests in fractional_knapsack.frac_knapsack
11 tests in 2 items.
11 passed and 0 failed.
Test passed.

@Hardvan Hardvan requested a review from cclauss October 24, 2023 14:23
Co-authored-by: Christian Clauss <cclauss@me.com>
@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 24, 2023

After adding this test case, this is the output:
r = sorted(zip(vl, wt), key=lambda x: x[0] / x[1], reverse=True)
TypeError: unsupported operand type(s) for /: 'str' and 'int'


1 items had failures:
1 of 12 in main.frac_knapsack
Test Failed 1 failures.

This suggests that the existing code cannot handle the case when the input parameters are of another unexpected type (string).

@Hardvan Hardvan requested a review from cclauss October 24, 2023 14:29
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2023
@algorithms-keeper algorithms-keeper bot removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 24, 2023
@cclauss cclauss merged commit aeee0f4 into TheAlgorithms:master Oct 24, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
* Add doctests for fractional knapsack

* Update greedy_methods/fractional_knapsack.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Run doctests

* Update greedy_methods/fractional_knapsack.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update greedy_methods/fractional_knapsack.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants