Tests for odd_even_transposition_parallel #10926

RaymondDashWu · 2023-10-24T22:45:55Z

Describe your change:

Contributes to #9943. It should be noted that there is currently a bug in this algo as described in #10925. Will fix in a separate PR after this gets merged.

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
Add test cases

Checklist:

cclauss · 2023-10-25T05:39:02Z

Your long builds are unique. Did you try running the doctests locally?
python3 -m doctest -v sorts/odd_even_transposition_parallel.py

cclauss · 2023-10-25T05:39:36Z

Or you can comment out your tests and see if builds start to work again.

cclauss · 2023-10-25T05:40:42Z

sorts/merge_insertion_sort.py ....                                       [ 93%]
sorts/merge_sort.py .                                                    [ 93%]
sorts/msd_radix_sort.py ....                                             [ 93%]
sorts/natural_sort.py .                                                  [ 93%]
sorts/odd_even_sort.py .                                                 [ 93%]
Error: The operation was canceled.

RaymondDashWu · 2023-10-25T06:44:12Z

This is what happens when I run it locally with python3 -m doctest -v sorts/odd_even_transposition_parallel.py. Likely the reason build is hanging. Interestingly though it runs fine when I cd into sorts and then run python3 -m doctest -v odd_even_transposition_parallel.py

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/homebrew/Cellar/python@3.11/3.11.6/Frameworks/Python.framework/Versions/3.11/lib/python3.11/multiprocessing/spawn.py", line 122, in spawn_main
    exitcode = _main(fd, parent_sentinel)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.11/3.11.6/Frameworks/Python.framework/Versions/3.11/lib/python3.11/multiprocessing/spawn.py", line 132, in _main
    self = reduction.pickle.load(from_parent)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'odd_even_transposition_parallel'

cclauss · 2023-10-25T12:13:52Z

sorts/odd_even_transposition_parallel.py

+    >>> odd_even_transposition(list(range(11)[::-1])) == sorted(list(range(11)[::-1]))
+    True
+    >>> odd_even_transposition(["a", "x", "c"]) == sorted(["x", "a", "c"])
+    True
+    >>> odd_even_transposition([1.9, 42.0, 2.8]) == sorted([1.9, 42.0, 2.8])
+    True
+    >>> odd_even_transposition([False, True, False]) == sorted([False, False, True])
+    True
+    >>> odd_even_transposition([1, 32.0, 9]) == sorted([False, False, True])
+    False
+    >>> odd_even_transposition([1, 32.0, 9]) == sorted([1.0, 32, 9.0])
+    True
+    >>> unsorted_list = [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429]
+    >>> odd_even_transposition(unsorted_list) == sorted(unsorted_list)
+    True
+    >>> unsorted_list = [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429]
+    >>> odd_even_transposition(unsorted_list) == sorted(unsorted_list + [1])
+    False
+    >>> odd_even_transposition([False, "a", 8]) == sorted([False, "a", 8])
+    Traceback (most recent call last):
+        ...
+    TypeError: '>' not supported between instances of 'bool' and 'str'
+    >>> odd_even_transposition([8, "a"]) == sorted(["a", 8])
+    Traceback (most recent call last):
+        ...
+    TypeError: '<' not supported between instances of 'str' and 'int'


Let's comment out the doctests and see if the build passes. Then we can add tests one or two at a time until we find the infinite loop.

Suggested change

>>> odd_even_transposition(list(range(11)[::-1])) == sorted(list(range(11)[::-1]))

True

>>> odd_even_transposition(["a", "x", "c"]) == sorted(["x", "a", "c"])

True

>>> odd_even_transposition([1.9, 42.0, 2.8]) == sorted([1.9, 42.0, 2.8])

True

>>> odd_even_transposition([False, True, False]) == sorted([False, False, True])

True

>>> odd_even_transposition([1, 32.0, 9]) == sorted([False, False, True])

False

>>> odd_even_transposition([1, 32.0, 9]) == sorted([1.0, 32, 9.0])

True

>>> unsorted_list = [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429]

>>> odd_even_transposition(unsorted_list) == sorted(unsorted_list)

True

>>> unsorted_list = [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429]

>>> odd_even_transposition(unsorted_list) == sorted(unsorted_list + [1])

False

>>> odd_even_transposition([False, "a", 8]) == sorted([False, "a", 8])

Traceback (most recent call last):

...

TypeError: '>' not supported between instances of 'bool' and 'str'

>>> odd_even_transposition([8, "a"]) == sorted(["a", 8])

Traceback (most recent call last):

...

TypeError: '<' not supported between instances of 'str' and 'int'

# >>> odd_even_transposition(list(range(11)[::-1])) == sorted(list(range(11)[::-1]))

True

# >>> odd_even_transposition(["a", "x", "c"]) == sorted(["x", "a", "c"])

True

# >>> odd_even_transposition([1.9, 42.0, 2.8]) == sorted([1.9, 42.0, 2.8])

True

# >>> odd_even_transposition([False, True, False]) == sorted([False, False, True])

True

# >>> odd_even_transposition([1, 32.0, 9]) == sorted([False, False, True])

False

# >>> odd_even_transposition([1, 32.0, 9]) == sorted([1.0, 32, 9.0])

True

>>> unsorted_list = [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429]

# >>> odd_even_transposition(unsorted_list) == sorted(unsorted_list)

True

>>> unsorted_list = [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429]

# >>> odd_even_transposition(unsorted_list) == sorted(unsorted_list + [1])

False

# >>> odd_even_transposition([False, "a", 8]) == sorted([False, "a", 8])

Traceback (most recent call last):

...

TypeError: '>' not supported between instances of 'bool' and 'str'

# >>> odd_even_transposition([8, "a"]) == sorted(["a", 8])

Traceback (most recent call last):

...

TypeError: '<' not supported between instances of 'str' and 'int'

Just finished pushing all the commits to experiment with. As expected, commenting out all the tests allowed the build to pass. I've made one commit for each test, leaving the rest of the tests commented out except that one. The only exception was the last 3, which were expected to throw exceptions as I couldn't even get those to work locally. If they all fail to build I'm not sure how to proceed.

OK. Please uncomment all the tests that work so that they run. Then leave a blank line and then the commented out tests that seem to run forever. I will look at those in my morning. Thanks for your persistence!!

That won't be necessary as each test failed individually! I'm not familiar enough with the way Python does parallelization but I suspect that has something to do with why these tests all fail.

After a lot of trial and error I finally figured it out! It had to do with the globally defined process lock. The only thing I couldn't figure out was how to test for multiple different data types. It threw out multiple exceptions with each of those tests and I couldn't figure out how to get those working in doctest. I tried adding # doctest: +IGNORE_EXCEPTION_DETAIL as well as playing around with ellipses (...) to no avail.

For example odd_even_transposition([False, "a", 8]) == sorted([False, "a", 8]) output:

Process Process-47: Process Process-46: Traceback (most recent call last): Traceback (most recent call last): ... TypeError: '<' not supported between instances of 'str' and 'bool' TypeError: '>' not supported between instances of 'bool' and 'str'

… odd_even_transposition_parallel_tests

* [ADD] tests for odd_even_transposition_parallel * adding another test because build failed 6 hrs * comment out all tests to see if it fails * list(range(10)[::-1]) test uncommented * [a, x, c] test uncommented * [1.9, 42.0, 2.8] test uncommented * [False, True, False] test uncommented * [1, 32.0, 9] test uncommented * [1, 32.0, 9] test uncommented * [-442, -98, -554, 266, -491, 985, -53, -529, 82, -429] test uncommented * test non global lock * [DEL] Testing multiple data types. Couldn't get doctest to work * [ADD] Comment on why non global process lock

[ADD] tests for odd_even_transposition_parallel

c9823cc

algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 24, 2023

adding another test because build failed 6 hrs

e6c73fc

cclauss reviewed Oct 25, 2023

View reviewed changes

comment out all tests to see if it fails

863acc8

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 25, 2023

RaymondDashWu added 7 commits October 25, 2023 13:13

list(range(10)[::-1]) test uncommented

4c4571c

[a, x, c] test uncommented

efe763c

[1.9, 42.0, 2.8] test uncommented

5fe87a5

[False, True, False] test uncommented

da3db5e

[1, 32.0, 9] test uncommented

fb363a0

[1, 32.0, 9] test uncommented

c1b711f

[-442, -98, -554, 266, -491, 985, -53, -529, 82, -429] test uncommented

d863f86

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 26, 2023

RaymondDashWu added 3 commits October 26, 2023 12:42

Merge branch 'master' of https://github.com/TheAlgorithms/Python into…

9a11af7

… odd_even_transposition_parallel_tests

test non global lock

5ba4627

[DEL] Testing multiple data types. Couldn't get doctest to work

d62a0a1

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 27, 2023

[ADD] Comment on why non global process lock

76d5932

cclauss approved these changes Oct 27, 2023

View reviewed changes

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 27, 2023

cclauss approved these changes Oct 27, 2023

View reviewed changes

cclauss merged commit 0eb1825 into TheAlgorithms:master Oct 27, 2023

RaymondDashWu deleted the odd_even_transposition_parallel_tests branch October 27, 2023 20:17

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests for odd_even_transposition_parallel #10926

Tests for odd_even_transposition_parallel #10926

RaymondDashWu commented Oct 24, 2023

cclauss commented Oct 25, 2023

cclauss commented Oct 25, 2023

cclauss commented Oct 25, 2023

RaymondDashWu commented Oct 25, 2023 •

edited

Loading

cclauss Oct 25, 2023 •

edited

Loading

RaymondDashWu Oct 25, 2023

cclauss Oct 25, 2023

RaymondDashWu Oct 26, 2023

RaymondDashWu Oct 27, 2023 •

edited

Loading

Tests for odd_even_transposition_parallel #10926

Tests for odd_even_transposition_parallel #10926

Conversation

RaymondDashWu commented Oct 24, 2023

Describe your change:

Checklist:

cclauss commented Oct 25, 2023

cclauss commented Oct 25, 2023

cclauss commented Oct 25, 2023

RaymondDashWu commented Oct 25, 2023 • edited Loading

cclauss Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

RaymondDashWu Oct 25, 2023

Choose a reason for hiding this comment

cclauss Oct 25, 2023

Choose a reason for hiding this comment

RaymondDashWu Oct 26, 2023

Choose a reason for hiding this comment

RaymondDashWu Oct 27, 2023 • edited Loading

Choose a reason for hiding this comment

RaymondDashWu commented Oct 25, 2023 •

edited

Loading

cclauss Oct 25, 2023 •

edited

Loading

RaymondDashWu Oct 27, 2023 •

edited

Loading