Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error tests in doctest and fix error message #10930

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add error tests in doctest and fix error message #10930

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e27b2af
Add error tests in doctest and fix error message
CouldNot Oct 25, 2023
5b5df87
Change AssertationError to ValueError
CouldNot Oct 26, 2023
4dc7a44
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion maths/prime_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,20 @@ def is_prime(number: int) -> bool:
True
>>> is_prime(67483)
False
>>> is_prime(16.1)
Traceback (most recent call last):
...
AssertionError: is_prime() only accepts positive integers
>>> is_prime(-4)
Traceback (most recent call last):
...
AssertionError: is_prime() only accepts positive integers
"""

# precondition
assert isinstance(number, int) and (
number >= 0
), "'number' must been an int and positive"
), "is_prime() only accepts positive integers"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this assert to a ValueError instead?


if 1 < number < 4:
# 2 and 3 are primes
Expand Down