Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integer Square Root Algorithm #10949

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Add Integer Square Root Algorithm #10949

merged 3 commits into from
Oct 29, 2023

Conversation

aqib-m31
Copy link
Contributor

Describe your change:

Implemented the Integer Square Root algorithm for efficiently calculating the square root of a non-negative integer 'x' rounded down to the nearest integer. The algorithm uses binary search to find the integer square root without using any
built-in exponent functions or operators.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 25, 2023
@cclauss cclauss enabled auto-merge (squash) October 29, 2023 10:56
@cclauss cclauss self-assigned this Oct 29, 2023
@cclauss cclauss merged commit 403d3b8 into TheAlgorithms:master Oct 29, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 29, 2023
@aqib-m31
Copy link
Contributor Author

Thank you @cclauss!
Could you please have a look at #10928 as well!

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@aqib-m31 @cclauss @sedatguzelsemme
Add Integer Square Root Algorithm (TheAlgorithms#10949)
627853d 
* Add Integer Square Root Algorithm

* Update integer_square_root.py

* Update integer_square_root.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqib-m31 @cclauss