Added doctest to double_hash.py #11020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
imSanko
approved these changes
Oct 27, 2023
| @@ -35,6 +35,33 @@ def __hash_double_function(self, key, data, increment): | |||
| return (increment * self.__hash_function_2(key, data)) % self.size_table | |||
|
|
|||
| def _collision_resolution(self, key, data=None): | |||
| """ | |||
| Examples: | |||
tianyizheng02
requested changes
Oct 27, 2023
Comment on lines
57
to
58
| 3. Try to add three data elements when the size is one | ||
| >>> dh = DoubleHash(2) |
There was a problem hiding this comment.
Suggested change
| 3. Try to add three data elements when the size is one | |
| >>> dh = DoubleHash(2) | |
| 3. Try to add three data elements when the size is one | |
| >>> dh = DoubleHash(1) |
Typo
There was a problem hiding this comment.
Typo
I tested adding elements to DoubleHash with size 1, to my surprise it resulted in getting stuck in infinite loop, where a new hash value tries to be calculated but is unable to.
For now I have changed that part of test. I'll soon be raising an issue and also will try to fix it.
tianyizheng02
approved these changes
Oct 27, 2023
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* Added doctest to double_hash.py * Update double_hash.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Contributes to #9943
Checklist: