Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bitap_string_match algo #11060

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Add bitap_string_match algo #11060

merged 5 commits into from
Oct 28, 2023

Conversation

edy252
Copy link
Contributor

@edy252 edy252 commented Oct 28, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 28, 2023
cclauss
cclauss reviewed Oct 28, 2023
View reviewed changes
pyproject.toml Outdated
@@ -135,5 +135,5 @@ omit = [
sort = "Cover"

[tool.codespell]
ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,toi,zar"
ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,toi,zar,bitap"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is in alphabetical order to make it easy to spot missing values and almost impossible to add duplicates.

cclauss
cclauss reviewed Oct 28, 2023
View reviewed changes
strings/bitap_string_match.py Outdated
Comment on lines 43 to 45
m: int = len(pattern)
if m == 0:
return 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All falsey values for pattern are equally dangerous as "".

Python and mypy are both smart enough to figure out without the type hint that if len(pattern) is assigned to m then m is an int.

Suggested change
m: int = len(pattern)
if m == 0:
return 0
if not pattern:
return 0
m = len(pattern)

strings/bitap_string_match.py Outdated
return -1

# Initial state of bit string 1110
state: int = ~1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
state: int = ~1
state = ~1

@cclauss cclauss self-assigned this Oct 28, 2023
@cclauss cclauss enabled auto-merge (squash) October 28, 2023 22:48
@cclauss cclauss merged commit e3eb9da into TheAlgorithms:master Oct 28, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2023
@edy252
Copy link
Contributor Author

edy252 commented Oct 28, 2023

Thank you this review!

@cclauss
Copy link
Member

cclauss commented Oct 29, 2023

🚀 Please give this repo a ⭐ if you have not already done so.

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@edy252 @sedatguzelsemme
Add bitap_string_match algo (TheAlgorithms#11060)
607e618 
* Add bitap_string_match algo

* Fix types

* Fix spelling and add ignore word

* Add suggested changes and change return type

* Resolve suggestions
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edy252 @cclauss