Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added doctest to detecting_english_programmatically.py #11135

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Added doctest to detecting_english_programmatically.py #11135

merged 1 commit into from
Nov 6, 2023

Conversation

Suyashd999
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 1, 2023
@zhudingsuifeng
Copy link

zhudingsuifeng commented Nov 1, 2023 via email

@BCGL
Copy link

BCGL commented Nov 1, 2023 via email

@wwowowo
Copy link

wwowowo commented Nov 1, 2023 via email

@Suyashd999
Copy link
Contributor Author

why are people replying in Chinese to this PR? even if they are, the translation doesn't makes sense at all!

imSanko
imSanko approved these changes Nov 2, 2023
View reviewed changes
strings/detecting_english_programmatically.py
@@ -25,6 +25,18 @@ def get_english_count(message: str) -> float:


def remove_non_letters(message: str) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice✅

This was referenced Nov 3, 2023
Closed
Closed
@Suyashd999
Copy link
Contributor Author

@cclauss can you review this PR? I have reached the limit of 5 open PRs

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 6, 2023
@cclauss cclauss merged commit fa508d7 into TheAlgorithms:master Nov 6, 2023
cclauss pushed a commit to cclauss/Python that referenced this pull request Jan 13, 2024
@Suyashd999 @cclauss
Added doctest to detecting_english_programmatically.py (TheAlgorithms…
07135d6 
…#11135)
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Suyashd999 @sedatguzelsemme
Added doctest to detecting_english_programmatically.py (TheAlgorithms…
8b0bcc4 
…#11135)
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@imSanko imSanko imSanko approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Suyashd999 @zhudingsuifeng @BCGL @wwowowo @cclauss @imSanko