Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore venv in build_directory_md.py #11156

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

FishyGitHubUser
Copy link
Contributor

@FishyGitHubUser FishyGitHubUser commented Nov 15, 2023

Describe your change:

Fixes #8736 - Ignores virtual environment named venv to prevent validate_filenames from reading it, and failing.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 15, 2023
@FishyGitHubUser
Copy link
Contributor Author

The added condition's compare value "venv" should have a standardized name, so anyone running a virtual environment will not get the same issue.

@cclauss cclauss enabled auto-merge (squash) November 16, 2023 11:00
@cclauss cclauss self-requested a review as a code owner November 16, 2023 11:00
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Nov 16, 2023
@cclauss cclauss merged commit 5f61af4 into TheAlgorithms:master Nov 16, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 16, 2023
@FishyGitHubUser FishyGitHubUser deleted the bugfix/ignore-venv branch November 16, 2023 11:07
eukub pushed a commit to eukub/Python that referenced this pull request Dec 2, 2023
Co-authored-by: MICHAEL CASTLE <CASTLM@tdm.local>
cclauss pushed a commit to cclauss/Python that referenced this pull request Jan 13, 2024
Co-authored-by: MICHAEL CASTLE <CASTLM@tdm.local>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
Co-authored-by: MICHAEL CASTLE <CASTLM@tdm.local>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit on windows fails on Validate filenames
2 participants