Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add graphs/ant_colony_optimization_algorithms.py #11163

Merged
merged 5 commits into from
Nov 25, 2023
Merged

add graphs/ant_colony_optimization_algorithms.py #11163

merged 5 commits into from
Nov 25, 2023

Conversation

Clarkzzzzz
Copy link
Contributor

Describe your change:

A simple example uses the ant colony optimization algorithm to solve the classic TSP problem.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 16, 2023
@Clarkzzzzz
Copy link
Contributor Author

Hello, The file that failed the test is not my file. What should I do?

cclauss
cclauss requested changes Nov 16, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Nov 17, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Nov 17, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Nov 17, 2023
@Clarkzzzzz Clarkzzzzz requested a review from cclauss November 17, 2023 10:52
@cclauss cclauss enabled auto-merge (squash) November 25, 2023 12:23
cclauss
cclauss approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to detect if there are no cities or ants_num < 1or iterations_num < 1 and raise ValueError.

@cclauss cclauss merged commit 4151a13 into TheAlgorithms:master Nov 25, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 25, 2023
@Clarkzzzzz
Copy link
Contributor Author

Thank you for the comprehensive review! I appreciate your valuable feedback. This is my first open-source library PR. Have a nice day!

eukub pushed a commit to eukub/Python that referenced this pull request Dec 2, 2023
@Clarkzzzzz @cclauss
@pre-commit-ci @eukub
add graphs/ant_colony_optimization_algorithms.py (TheAlgorithms#11163)
8ecbc70 
* add ant_colonyant_colony_optimization_algorithms.py

* Modify details

* Modify type annotation

* Add tests for KeyError, IndexError, StopIteration, etc.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cclauss added a commit to cclauss/Python that referenced this pull request Jan 13, 2024
@Clarkzzzzz @cclauss @pre-commit-ci
add graphs/ant_colony_optimization_algorithms.py (TheAlgorithms#11163)
341559d 
* add ant_colonyant_colony_optimization_algorithms.py

* Modify details

* Modify type annotation

* Add tests for KeyError, IndexError, StopIteration, etc.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Clarkzzzzz @cclauss
@pre-commit-ci @sedatguzelsemme
add graphs/ant_colony_optimization_algorithms.py (TheAlgorithms#11163)
b907292 
* add ant_colonyant_colony_optimization_algorithms.py

* Modify details

* Modify type annotation

* Add tests for KeyError, IndexError, StopIteration, etc.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
require descriptive names This PR needs descriptive function and/or variable names
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Clarkzzzzz @cclauss