use format to remove '0b' #11307
use format to remove '0b' #11307
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -35,8 +35,8 @@ def binary_and(a: int, b: int) -> str: | |||
| if a < 0 or b < 0: | |||
| raise ValueError("the value of both inputs must be positive") | |||
|
|
|||
| a_binary = str(bin(a))[2:] # remove the leading "0b" | |||
There was a problem hiding this comment.
Why we need to more the comments??
In the given line of code, the comment is explaining what the line does, which is to remove the leading "0b" from the binary representation of the integer a. Comments are useful for making the code more understandable to other developers (or to your future self) who might read the code later.
There was a problem hiding this comment.
When using the format, "0b" is not included in the output, as it generates a string of 0s and 1s directly. As for the comment, would "converting to binary string" accurately reflect the operation? If so, I would be happy to implement these changes. Your feedback is valuable.
There was a problem hiding this comment.
I think it's fine to remove the comments here. format(_, "b") is much more transparent about its purpose of converting an int to binary, at least compared to str(bin(_))[2:], so if the reader knows what the format function does, then they know what this line of code does. Plus, the variable name a_binary already makes it clear that this line converts a to binary.
| @@ -35,8 +35,8 @@ def binary_and(a: int, b: int) -> str: | |||
| if a < 0 or b < 0: | |||
| raise ValueError("the value of both inputs must be positive") | |||
|
|
|||
| a_binary = str(bin(a))[2:] # remove the leading "0b" | |||
There was a problem hiding this comment.
I think it's fine to remove the comments here. format(_, "b") is much more transparent about its purpose of converting an int to binary, at least compared to str(bin(_))[2:], so if the reader knows what the format function does, then they know what this line of code does. Plus, the variable name a_binary already makes it clear that this line converts a to binary.
|
Thanks for your contribution! |
* use format to remove '0b' * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: error message for float input --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* use format to remove '0b' * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: error message for float input --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* use format to remove '0b' * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: error message for float input --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Describe your change:
use format to remove '0b'
Checklist: