Skip to content

Enable ruff S105 rule #11343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Enable ruff S105 rule #11343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05b38df
Enable ruff S105 rule
MaximSmolskiy Apr 2, 2024
61dc7fc
Update web_programming/recaptcha_verification.py
cclauss Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ lint.ignore = [ # `ruff rule S101` for a description of that rule
"PT018", # Assertion should be broken down into multiple parts
"RUF00", # Ambiguous unicode character and other rules
"S101", # Use of `assert` detected -- DO NOT FIX
"S105", # Possible hardcoded password: 'password'
"S113", # Probable use of requests call without timeout -- FIX ME
"S311", # Standard pseudo-random generators are not suitable for cryptographic purposes -- FIX ME
"SLF001", # Private member accessed: `_Iterator` -- FIX ME
Expand Down
2 changes: 1 addition & 1 deletion web_programming/recaptcha_verification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

def login_using_recaptcha(request):
# Enter your recaptcha secret key here
secret_key = "secretKey"
secret_key = "secretKey" # noqa: S105
url = "https://www.google.com/recaptcha/api/siteverify"

# when method is not POST, direct user to login page
Expand Down