Fix some ARG002 per file ignores #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
algorithms-keeper
bot
removed
the
tests are failing
cclauss
reviewed
May 1, 2024
audio_filters/show_response.py
Outdated
| @@ -8,7 +8,7 @@ | |||
|
|
|||
|
|
|||
| class FilterType(Protocol): | |||
| def process(self, sample: float) -> float: | |||
| def process(self, sample: float) -> float: # noqa: ARG002 | |||
There was a problem hiding this comment.
What would happen if we delete the unused variables?
There was a problem hiding this comment.
This class is used as interface, so I made this method absctract. Now there are no problems with unused method argument in this place
cclauss
reviewed
May 1, 2024
| @@ -173,7 +173,7 @@ def _set_value(self, key, data): | |||
| self.values[key] = data | |||
| self._keys[key] = data | |||
|
|
|||
| def _collision_resolution(self, key, data=None): | |||
| def _collision_resolution(self, key, data=None): # noqa: ARG002 | |||
There was a problem hiding this comment.
Yes. Done. noqa left in data_structures/hashing/quadratic_probing.py where this method is overridden
cclauss
approved these changes
May 1, 2024
There was a problem hiding this comment.
OK!
We get these warnings towards the end of the GItHub build test run...
web_programming/instagram_crawler.py . [ 99%]
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/coverage/report_core.py:115: CoverageWarning: Couldn't parse '/home/runner/work/Python/Python/config-3.py': No source for code: '/home/runner/work/Python/Python/config-3.py'. (couldnt-parse)
coverage._warn(msg, slug="couldnt-parse")
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/coverage/report_core.py:115: CoverageWarning: Couldn't parse '/home/runner/work/Python/Python/config.py': No source for code: '/home/runner/work/Python/Python/config.py'. (couldnt-parse)
coverage._warn(msg, slug="couldnt-parse")
web_programming/test_fetch_github_info.py . [100%]
=============================== warnings summary ===============================
<frozen importlib._bootstrap>:488
<frozen importlib._bootstrap>:488: DeprecationWarning: Type google._upb._message.MessageMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.
<frozen importlib._bootstrap>:488
<frozen importlib._bootstrap>:488: DeprecationWarning: Type google._upb._message.ScalarMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.
linear_algebra/src/gaussian_elimination_pivoting/gaussian_elimination_pivoting.py::linear_algebra.src.gaussian_elimination_pivoting.gaussian_elimination_pivoting.solve_linear_system
/home/runner/work/Python/Python/linear_algebra/src/gaussian_elimination_pivoting/gaussian_elimination_pivoting.py:55: RuntimeWarning: invalid value encountered in scalar divide
ab[i, column_num - 1]
sorts/odd_even_transposition_parallel.py: 45 warnings
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/multiprocessing/popen_fork.py:66: DeprecationWarning: This process (pid=1839) is multi-threaded, use of fork() may lead to deadlocks in the child.
self.pid = os.fork()
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* Fix some ARG002 per file ignores * Fix * updating DIRECTORY.md * Fix review issue * Fix review issue --------- Co-authored-by: MaximSmolskiy <MaximSmolskiy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fix some
ARG002per file ignoresChecklist: