Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ruff UP031 rule #11388

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Enable ruff UP031 rule #11388

merged 1 commit into from
Apr 30, 2024

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Enable ruff UP031 rule

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@MaximSmolskiy MaximSmolskiy requested a review from cclauss as a code owner April 29, 2024 22:52
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass awaiting reviews This PR is ready to be reviewed labels Apr 29, 2024
@MaximSmolskiy MaximSmolskiy force-pushed the enable-ruff-UP031-rule branch from 3298613 to 34db3c5 Compare April 29, 2024 23:08
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Apr 29, 2024
@MaximSmolskiy MaximSmolskiy force-pushed the enable-ruff-UP031-rule branch from 34db3c5 to b6ad499 Compare April 29, 2024 23:11
@MaximSmolskiy MaximSmolskiy mentioned this pull request Apr 29, 2024
Merged
cclauss
cclauss approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cclauss cclauss merged commit 2d6be5f into TheAlgorithms:master Apr 30, 2024
3 checks passed
@MaximSmolskiy MaximSmolskiy deleted the enable-ruff-UP031-rule branch April 30, 2024 07:01
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@MaximSmolskiy @sedatguzelsemme
Enable ruff UP031 rule (TheAlgorithms#11388)
b69162e
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @cclauss