Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create count_vowels.py #11474

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Create count_vowels.py #11474

merged 2 commits into from
Jul 4, 2024

Conversation

its-100rabh
Copy link
Contributor

@its-100rabh its-100rabh commented Jul 2, 2024 •
edited
Loading

Describe your change:

A program to check the number of vowels in a given string.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jul 2, 2024
imSanko
imSanko approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Nice the Different input sizes (5, 4, 3, 2, 1)
  • Different ranges of values (small, large, mixed)
  • Already sorted inputs
  • Reversed sorted inputs
  • Edge cases (single element, two elements)

@its-100rabh
Copy link
Contributor Author

  • Nice the Different input sizes (5, 4, 3, 2, 1)
  • Different ranges of values (small, large, mixed)
  • Already sorted inputs
  • Reversed sorted inputs
  • Edge cases (single element, two elements)

Should I add these test cases to the existing test cases?

@its-100rabh its-100rabh requested a review from imSanko July 4, 2024 07:06
@cclauss cclauss enabled auto-merge (squash) July 4, 2024 18:16
@cclauss cclauss merged commit c1dc8e9 into TheAlgorithms:master Jul 4, 2024
3 checks passed
abhijitmjj pushed a commit to abhijitmjj/Python that referenced this pull request Jul 5, 2024
@its-100rabh @pre-commit-ci @abhijitmjj
Create count_vowels.py (TheAlgorithms#11474)
01c4194 
* Create count_vowels.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@its-100rabh @pre-commit-ci @sedatguzelsemme
Create count_vowels.py (TheAlgorithms#11474)
73f4a64 
* Create count_vowels.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@its-100rabh @pre-commit-ci @cclauss
Create count_vowels.py (TheAlgorithms#11474)
3388251 
* Create count_vowels.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@its-100rabh @pre-commit-ci @cclauss
Create count_vowels.py (TheAlgorithms#11474)
c76d955 
* Create count_vowels.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@imSanko imSanko Awaiting requested review from imSanko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@its-100rabh @cclauss @imSanko