Implemented KD Tree Data Structure #11532

Ramy-Badr-Ahmed · 2024-08-28T11:29:03Z

Describe your change:

This pull request adds an implementation of the KD-Tree data structure along with related functionalities, such as nearest neighbor searches.

Definition: The KD-Tree is a space-partitioning data structure used for organizing points in a k-dimensional space. (URL: KD-Tree)

Implementation Details:

build_kdtree.py: Contains the function to build a KD-Tree from a set of points.
nearest_neighbor_search.py: Implements the nearest neighbor search algorithm using the built KD-Tree.
kd_node.py: Defines the KDNode class representing nodes in the KD-Tree.

Example Usage:

hypercube_points.py: Provides a function to generate random points uniformly distributed within an n-dimensional hypercube.
example_usage.py: Demonstrates how to use the KD-Tree implementation with the generated random hypercube points and querying for nearest neighbors.

Unit Tests:

test_kdtree.py: Validates the correctness of the KD Tree implementation, including tests for building the tree, querying for nearest neighbors and testing edge cases.

Reference

The Algorithm Design Manual, Latest edition

for more information, see https://pre-commit.ci

…d_tree/example_usage.py

…d_tree/hypercube_points.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/kd_tree/build_kdtree.py

data_structures/kd_tree/example/hypercube_points.py

data_structures/kd_tree/kd_node.py

data_structures/kd_tree/nearest_neighbour_search.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/kd_tree/build_kdtree.py

data_structures/kd_tree/example/example_usage.py

data_structures/kd_tree/example/hypercube_points.py

data_structures/kd_tree/nearest_neighbour_search.py

for more information, see https://pre-commit.ci

…into feature/kd-tree-implementation # Conflicts: # data_structures/kd_tree/nearest_neighbour_search.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/kd_tree/build_kdtree.py

data_structures/kd_tree/example/example_usage.py

data_structures/kd_tree/example/hypercube_points.py

data_structures/kd_tree/nearest_neighbour_search.py

for more information, see https://pre-commit.ci

Ramy-Badr-Ahmed

Added docstrings, & typehints

Ramy-Badr-Ahmed

added pytests, changed assertion style

data_structures/kd_tree/tests/test_kdtree.py

data_structures/kd_tree/build_kdtree.py

data_structures/kd_tree/kd_node.py

data_structures/kd_tree/nearest_neighbour_search.py

for more information, see https://pre-commit.ci

cclauss · 2024-09-03T11:59:13Z

I made some changes... Let's see if it passes.

for more information, see https://pre-commit.ci

Ramy-Badr-Ahmed · 2024-09-03T12:34:58Z

I made some changes... Let's see if it passes.

Works now :-)

cclauss

Nice... Nodes are usually great candidates for dataclass.

Thanks for doing this.

* Implemented KD-Tree Data Structure * Implemented KD-Tree Data Structure. updated DIRECTORY.md. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/example_usage.py * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/hypercube_points.py * added typehints and docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docstring for search() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests. Updated docstrings/typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests and used | for type annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * E501 for build_kdtree.py, hypercube_points.py, nearest_neighbour_search.py * I001 for example_usage.py and test_kdtree.py * I001 for example_usage.py and test_kdtree.py * Update data_structures/kd_tree/build_kdtree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added new test cases requested in Review. Refactored the test_build_kdtree() to include various checks. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considered ruff errors * Considered ruff errors * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kd_node.py * imported annotations from __future__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>

Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554.

* Implemented KD-Tree Data Structure * Implemented KD-Tree Data Structure. updated DIRECTORY.md. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/example_usage.py * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/hypercube_points.py * added typehints and docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docstring for search() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests. Updated docstrings/typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests and used | for type annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * E501 for build_kdtree.py, hypercube_points.py, nearest_neighbour_search.py * I001 for example_usage.py and test_kdtree.py * I001 for example_usage.py and test_kdtree.py * Update data_structures/kd_tree/build_kdtree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added new test cases requested in Review. Refactored the test_build_kdtree() to include various checks. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considered ruff errors * Considered ruff errors * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kd_node.py * imported annotations from __future__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Implementation of the suffix tree data structure * Adding data to DIRECTORY.md * Minor file renaming * minor correction * renaming in DIRECTORY.md * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-1 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-2 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-3 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-4 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-5 * Implemented Suffix Tree Data Structure. Added some comments to my files in #11532, #11554. * updating DIRECTORY.md * Implemented Suffix Tree Data Structure. Added some comments to my files in #11532, #11554. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Ramy-Badr-Ahmed <Ramy-Badr-Ahmed@users.noreply.github.com>

* Implemented KD-Tree Data Structure * Implemented KD-Tree Data Structure. updated DIRECTORY.md. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/example_usage.py * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/hypercube_points.py * added typehints and docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docstring for search() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests. Updated docstrings/typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests and used | for type annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * E501 for build_kdtree.py, hypercube_points.py, nearest_neighbour_search.py * I001 for example_usage.py and test_kdtree.py * I001 for example_usage.py and test_kdtree.py * Update data_structures/kd_tree/build_kdtree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added new test cases requested in Review. Refactored the test_build_kdtree() to include various checks. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considered ruff errors * Considered ruff errors * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kd_node.py * imported annotations from __future__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>

* Implemented KD-Tree Data Structure * Implemented KD-Tree Data Structure. updated DIRECTORY.md. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/example_usage.py * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/hypercube_points.py * added typehints and docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docstring for search() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests. Updated docstrings/typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests and used | for type annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * E501 for build_kdtree.py, hypercube_points.py, nearest_neighbour_search.py * I001 for example_usage.py and test_kdtree.py * I001 for example_usage.py and test_kdtree.py * Update data_structures/kd_tree/build_kdtree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added new test cases requested in Review. Refactored the test_build_kdtree() to include various checks. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considered ruff errors * Considered ruff errors * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kd_node.py * imported annotations from __future__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Implementation of the suffix tree data structure * Adding data to DIRECTORY.md * Minor file renaming * minor correction * renaming in DIRECTORY.md * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-1 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-2 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-3 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-4 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-5 * Implemented Suffix Tree Data Structure. Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554. * updating DIRECTORY.md * Implemented Suffix Tree Data Structure. Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Ramy-Badr-Ahmed <Ramy-Badr-Ahmed@users.noreply.github.com>

* Implemented KD-Tree Data Structure * Implemented KD-Tree Data Structure. updated DIRECTORY.md. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/example_usage.py * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/hypercube_points.py * added typehints and docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docstring for search() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests. Updated docstrings/typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests and used | for type annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * E501 for build_kdtree.py, hypercube_points.py, nearest_neighbour_search.py * I001 for example_usage.py and test_kdtree.py * I001 for example_usage.py and test_kdtree.py * Update data_structures/kd_tree/build_kdtree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added new test cases requested in Review. Refactored the test_build_kdtree() to include various checks. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considered ruff errors * Considered ruff errors * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kd_node.py * imported annotations from __future__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>

* Implemented KD-Tree Data Structure * Implemented KD-Tree Data Structure. updated DIRECTORY.md. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Create __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/example_usage.py * Replaced legacy `np.random.rand` call with `np.random.Generator` in kd_tree/hypercube_points.py * added typehints and docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docstring for search() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests. Updated docstrings/typehints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated tests and used | for type annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * E501 for build_kdtree.py, hypercube_points.py, nearest_neighbour_search.py * I001 for example_usage.py and test_kdtree.py * I001 for example_usage.py and test_kdtree.py * Update data_structures/kd_tree/build_kdtree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/kd_tree/example/hypercube_points.py Co-authored-by: Christian Clauss <cclauss@me.com> * Added new test cases requested in Review. Refactored the test_build_kdtree() to include various checks. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considered ruff errors * Considered ruff errors * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update kd_node.py * imported annotations from __future__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Implementation of the suffix tree data structure * Adding data to DIRECTORY.md * Minor file renaming * minor correction * renaming in DIRECTORY.md * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-1 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-2 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-3 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-4 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Considering ruff part-5 * Implemented Suffix Tree Data Structure. Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554. * updating DIRECTORY.md * Implemented Suffix Tree Data Structure. Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Ramy-Badr-Ahmed <Ramy-Badr-Ahmed@users.noreply.github.com>

Ramy-Badr-Ahmed and others added 3 commits August 28, 2024 13:09

Implemented KD-Tree Data Structure

0d6985c

Implemented KD-Tree Data Structure. updated DIRECTORY.md.

6665d23

[pre-commit.ci] auto fixes from pre-commit.com hooks

6b3d47e

for more information, see https://pre-commit.ci

algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 28, 2024

Ramy-Badr-Ahmed and others added 2 commits August 28, 2024 14:02

Create __init__.py

4203cda

[pre-commit.ci] auto fixes from pre-commit.com hooks

3222bd3

for more information, see https://pre-commit.ci

Ramy-Badr-Ahmed changed the title ~~Feature/kd tree implementation~~ kd tree data structure implementation Aug 28, 2024

This comment was marked as outdated.

Sign in to view

Ramy-Badr-Ahmed added 2 commits August 28, 2024 19:39

Replaced legacy np.random.rand call with np.random.Generator in k…

a41ae5b

…d_tree/example_usage.py

Replaced legacy np.random.rand call with np.random.Generator in k…

1668d73

…d_tree/hypercube_points.py

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Aug 28, 2024

algorithms-keeper bot reviewed Aug 28, 2024

View reviewed changes

added typehints and docstrings

81d6917

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Aug 28, 2024

algorithms-keeper bot reviewed Aug 28, 2024

View reviewed changes

pre-commit-ci bot and others added 3 commits August 28, 2024 18:02

[pre-commit.ci] auto fixes from pre-commit.com hooks

6cddcbd

for more information, see https://pre-commit.ci

docstring for search()

8b238d1

Merge remote-tracking branch 'origin/feature/kd-tree-implementation' …

cd1dd9f

…into feature/kd-tree-implementation # Conflicts: # data_structures/kd_tree/nearest_neighbour_search.py

algorithms-keeper bot reviewed Aug 28, 2024

View reviewed changes

pre-commit-ci bot and others added 3 commits August 28, 2024 18:09

[pre-commit.ci] auto fixes from pre-commit.com hooks

ead2838

for more information, see https://pre-commit.ci

Added tests. Updated docstrings/typehints

543584c

[pre-commit.ci] auto fixes from pre-commit.com hooks

ad31f83

for more information, see https://pre-commit.ci

Ramy-Badr-Ahmed commented Aug 28, 2024

View reviewed changes

updated tests and used | for type annotations

1322921

algorithms-keeper bot removed the require tests Tests [doctest/unittest/pytest] are required label Aug 28, 2024

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 3, 2024

cclauss reviewed Sep 3, 2024

View reviewed changes

data_structures/kd_tree/tests/test_kdtree.py Outdated Show resolved Hide resolved

Ramy-Badr-Ahmed commented Sep 3, 2024

View reviewed changes

data_structures/kd_tree/tests/test_kdtree.py Show resolved Hide resolved

Ramy-Badr-Ahmed commented Sep 3, 2024

View reviewed changes

data_structures/kd_tree/tests/test_kdtree.py Show resolved Hide resolved

Ramy-Badr-Ahmed requested a review from cclauss September 3, 2024 11:47

cclauss reviewed Sep 3, 2024

View reviewed changes

cclauss and others added 2 commits September 3, 2024 13:58

Apply suggestions from code review

3c09ac1

[pre-commit.ci] auto fixes from pre-commit.com hooks

bab43e7

for more information, see https://pre-commit.ci

Update kd_node.py

a10ff15

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 3, 2024

Ramy-Badr-Ahmed and others added 2 commits September 3, 2024 14:29

imported annotations from __future__

d77a285

[pre-commit.ci] auto fixes from pre-commit.com hooks

0426806

for more information, see https://pre-commit.ci

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 3, 2024

cclauss enabled auto-merge (squash) September 3, 2024 12:38

cclauss approved these changes Sep 3, 2024

View reviewed changes

cclauss merged commit f16d38f into TheAlgorithms:master Sep 3, 2024
3 checks passed

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 3, 2024

Ramy-Badr-Ahmed changed the title ~~kd tree data structure implementation~~ KD Tree Data Structure Implementation Sep 21, 2024

Ramy-Badr-Ahmed mentioned this pull request Sep 26, 2024

Bhavesh9908/Building a KD-Tree from Points #11547

Open

16 tasks

Ramy-Badr-Ahmed changed the title ~~KD Tree Data Structure Implementation~~ Implemented KD Tree Data Structure Sep 26, 2024

Ramy-Badr-Ahmed added a commit to Ramy-Badr-Ahmed/Python-DSA that referenced this pull request Sep 28, 2024

Implemented Suffix Tree Data Structure.

d8eb924

Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554.

Ramy-Badr-Ahmed added a commit to Ramy-Badr-Ahmed/Python-DSA that referenced this pull request Sep 28, 2024

Implemented Suffix Tree Data Structure.

3a6c8a3

Added some comments to my files in TheAlgorithms#11532, TheAlgorithms#11554.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented KD Tree Data Structure #11532

Implemented KD Tree Data Structure #11532

Ramy-Badr-Ahmed commented Aug 28, 2024 •

edited

Loading

This comment was marked as outdated.

algorithms-keeper bot left a comment

algorithms-keeper bot left a comment

algorithms-keeper bot left a comment

Ramy-Badr-Ahmed left a comment •

edited

Loading

Ramy-Badr-Ahmed left a comment •

edited

Loading

cclauss commented Sep 3, 2024

Ramy-Badr-Ahmed commented Sep 3, 2024

cclauss left a comment

Implemented KD Tree Data Structure #11532

Implemented KD Tree Data Structure #11532

Conversation

Ramy-Badr-Ahmed commented Aug 28, 2024 • edited Loading

Describe your change:

This comment was marked as outdated.

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Ramy-Badr-Ahmed left a comment • edited Loading

Choose a reason for hiding this comment

Ramy-Badr-Ahmed left a comment • edited Loading

Choose a reason for hiding this comment

cclauss commented Sep 3, 2024

Ramy-Badr-Ahmed commented Sep 3, 2024

cclauss left a comment

Choose a reason for hiding this comment

Ramy-Badr-Ahmed commented Aug 28, 2024 •

edited

Loading

Ramy-Badr-Ahmed left a comment •

edited

Loading

Ramy-Badr-Ahmed left a comment •

edited

Loading