Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balance parenthesis (add closing bracket) #11563

Merged
merged 2 commits into from
Sep 24, 2024
Merged

balance parenthesis (add closing bracket) #11563

merged 2 commits into from
Sep 24, 2024

Conversation

apples53
Copy link
Contributor

@apples53 apples53 commented Sep 12, 2024 •
edited
Loading

Describe your change:

Balanced the parenthesis by adding closing parenthesis.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

imSanko
imSanko approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops! That a little Typo, wait for your merge.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Sep 24, 2024
@tianyizheng02 tianyizheng02 merged commit 9b5641d into TheAlgorithms:master Sep 24, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 24, 2024
@tianyizheng02
Copy link
Contributor

Thanks for your fix!

cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@apples53 @tianyizheng02 @cclauss
balance parenthesis (add closing bracket) (TheAlgorithms#11563)
ed86d69 
* balance parenthesis (add closing bracket)

* Apply suggestions from code review

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@apples53 @tianyizheng02 @cclauss
balance parenthesis (add closing bracket) (TheAlgorithms#11563)
006034b 
* balance parenthesis (add closing bracket)

* Apply suggestions from code review

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@imSanko imSanko imSanko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apples53 @tianyizheng02 @imSanko