-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts for closing pull requests for Hacktoberfest #11587
Scripts for closing pull requests for Hacktoberfest #11587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we increase the PR limit to something higher than 200? We regularly have open PR counts larger than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly I'm not great with bash scripting, but the scripts look right to me. I trust that they work as intended if these are the same scripts that you just used clean up our open PRs, which appears to have been successful.
Just passing by here since I got assigned in this so the following is a question and maybe a suggestion... - is it worth doing this in a These seem to be repeatable tasks and would be easier to do them directly from the GitHub UI for maintainers. |
I hesitate to automate this too much because we run it rarely and closing other people's work is something we should do with some deliberation and not too much automation. |
Each year we prepare for Hacktoberfest by clearing out old pull requests to simplify things for project maintainers.
We had 211 open pull requests; after running these scripts, we have 126. ~40% of our Open PRs were closed.
@MaximSmolskiy Your review, please.