Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts for closing pull requests for Hacktoberfest #11587

Merged

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Sep 30, 2024

Each year we prepare for Hacktoberfest by clearing out old pull requests to simplify things for project maintainers.

We had 211 open pull requests; after running these scripts, we have 126. ~40% of our Open PRs were closed.

@MaximSmolskiy Your review, please.

Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we increase the PR limit to something higher than 200? We regularly have open PR counts larger than that.

Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I'm not great with bash scripting, but the scripts look right to me. I trust that they work as intended if these are the same scripts that you just used clean up our open PRs, which appears to have been successful.

@cclauss cclauss merged commit a9ca110 into TheAlgorithms:master Sep 30, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 30, 2024
@cclauss cclauss deleted the scripts_for_closing_pull_requests branch September 30, 2024 10:49
@tjgurwara99
Copy link
Member

Just passing by here since I got assigned in this so the following is a question and maybe a suggestion... - is it worth doing this in a workflow_dispatch based CI action? https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch

These seem to be repeatable tasks and would be easier to do them directly from the GitHub UI for maintainers.

@cclauss
Copy link
Member Author

cclauss commented Sep 30, 2024

I hesitate to automate this too much because we run it rarely and closing other people's work is something we should do with some deliberation and not too much automation.

@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.