-
-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Exponential Search with binary search for improved perfor… #11666
Conversation
…mance on large sorted arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
searches/Exponential_Search.py
Outdated
from bisect import bisect_left | ||
|
||
# Binary search function | ||
def binary_search(arr, left, right, target): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: binary_search
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file searches/Exponential_Search.py
, please provide doctest for the function binary_search
Please provide type hint for the parameter: arr
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
Please provide type hint for the parameter: target
searches/Exponential_Search.py
Outdated
return -1 | ||
|
||
# Exponential search function | ||
def exponential_search(arr, target): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: exponential_search
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file searches/Exponential_Search.py
, please provide doctest for the function exponential_search
Please provide type hint for the parameter: arr
Please provide type hint for the parameter: target
for more information, see https://pre-commit.ci
…h functions. Improved code documentation and ensured testability.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…mance on large sorted arrays.
Describe your change:
Checklist: