Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated has_loop lookup from O(n) to O(1) #11669

Merged

Conversation

1227haran
Copy link
Contributor

@1227haran 1227haran commented Oct 2, 2024

Describe your change:

visited variable is declared as a list, hence node in visited takes a TC of O(n). This issue is fixed by declaring visited as a set reducing the lookup TC to O(1).

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@1227haran 1227haran changed the title Optimized O(n) to O(1) Updated has_loop lookup from O(n) to O(1) Oct 2, 2024
@1227haran
Copy link
Contributor Author

All the tests are passing, please approve my PR

@tianyizheng02 tianyizheng02 merged commit 918fa8b into TheAlgorithms:master Oct 2, 2024
3 checks passed
@tianyizheng02
Copy link
Contributor

Thanks for your contribution!

@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants