Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implemented Matrix Exponentiation Method #11747

Merged
merged 29 commits into from
Oct 4, 2024
Merged

feat: Implemented Matrix Exponentiation Method #11747

merged 29 commits into from
Oct 4, 2024

Conversation

Acuspeedster
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Acuspeedster and others added 27 commits October 1, 2024 21:43
@Acuspeedster
feat: add Matrix Exponentiation method
f5211cc 
docs: updated the header documentation and added new documentation for
the new function.
@Acuspeedster
feat: added new function matrix exponetiation method
95421d7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
adf10bf 
for more information, see https://pre-commit.ci
@Acuspeedster
feat: This function uses the tail-recursive form of the Euclidean alg…
ba1cbc6 
…orithm to calculate
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fd37108 
for more information, see https://pre-commit.ci
@Acuspeedster
reduced the number of characters per line in the comments
50fd058
@Acuspeedster
Merge branch 'branch1' of https://github.com/Acuspeedster/Python into…
d6fec67 
… branch1
@Acuspeedster
removed unwanted code
ede7215
@Acuspeedster
feat: Implemented a new function to swaap numbers without dummy variable
0f939a8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5dc67f8 
for more information, see https://pre-commit.ci
@Acuspeedster
removed previos code
b581cf5
@Acuspeedster
removed the previous code
3ad4b6a
@Acuspeedster
Done with the required changes
31c5645
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6ee1a40 
for more information, see https://pre-commit.ci
@Acuspeedster
Done with the required changes
e48a3f3
@Acuspeedster
Merge branch 'branch1' of https://github.com/Acuspeedster/Python into…
8085e66 
… branch1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f82bd8c 
for more information, see https://pre-commit.ci
@Acuspeedster
Done with the required changes
8bf1389
@Acuspeedster
Merge branch 'branch1' of https://github.com/Acuspeedster/Python into…
7860646 
… branch1
@Acuspeedster
Done with the required changes
9ffd634
@Acuspeedster
Done with the required changes
4e2456f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
07ed6b9 
for more information, see https://pre-commit.ci
@Acuspeedster @tianyizheng02
Update maths/fibonacci.py
955c792 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
70dd92d 
for more information, see https://pre-commit.ci
@Acuspeedster
Done with the required changes
1909143
@Acuspeedster
Merge branch 'branch1' of https://github.com/Acuspeedster/Python into…
6cc39c0 
… branch1
@Acuspeedster
Done with the required changes
b7db4ca
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 4, 2024
tianyizheng02
tianyizheng02 requested changes Oct 4, 2024
View reviewed changes
maths/fibonacci.py
Comment on lines +265 to +268
>>> matrix_pow_np(m, -1)
Traceback (most recent call last):
...
ValueError: power is negative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code never actually checks whether the power is negative. I think this is why your tests are never finishing: this test is just running in an infinite loop with power = -1, -2, -3, ...

@Acuspeedster
Copy link
Contributor Author

@tianyizheng02 I am done with the changes please re-review this.

@tianyizheng02 tianyizheng02 merged commit 9a572de into TheAlgorithms:master Oct 4, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2024
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acuspeedster @tianyizheng02