Added max_sum_bst.py #11832
Added max_sum_bst.py #11832
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,68 @@ | |||
| class TreeNode: | |||
| def __init__(self, val=0, left=None, right=None): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: val
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
| self.left = left | ||
| self.right = right | ||
|
|
||
| def maxSumBST(root: TreeNode) -> int: |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: maxSumBST
| """ | ||
| ans = 0 | ||
|
|
||
| def solver(node): |
There was a problem hiding this comment.
Please provide return type hint for the function: solver. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/max_sum_BST.py, please provide doctest for the function solver
Please provide type hint for the parameter: node
| if not node: | ||
| return True, float('inf'), float('-inf'), 0 # Valid BST, min, max, sum | ||
|
|
||
| isLeftValid, min_left, max_left, sum_left = solver(node.left) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: isLeftValid
| return True, float('inf'), float('-inf'), 0 # Valid BST, min, max, sum | ||
|
|
||
| isLeftValid, min_left, max_left, sum_left = solver(node.left) | ||
| isRightValid, min_right, max_right, sum_right = solver(node.right) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: isRightValid
for more information, see https://pre-commit.ci
…thon into max_sum_binary_tree
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,64 @@ | |||
| class TreeNode: | |||
| def __init__(self, val=0, left=None, right=None) -> None: | |||
There was a problem hiding this comment.
Please provide type hint for the parameter: val
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
| """ | ||
| ans = 0 | ||
|
|
||
| def solver(node) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/max_sum_BST.py, please provide doctest for the function solver
Please provide type hint for the parameter: node
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,63 @@ | |||
| class TreeNode: | |||
| def __init__(self, val=0, left=None, right=None) -> None: | |||
There was a problem hiding this comment.
Please provide type hint for the parameter: val
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
| """ | ||
| ans = 0 | ||
|
|
||
| def solver(node) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/maximum_sum_bst.py, please provide doctest for the function solver
Please provide type hint for the parameter: node
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,63 @@ | |||
| class TreeNode: | |||
| def __init__(self, val=0, left=None, right=None) -> None: | |||
There was a problem hiding this comment.
Please provide type hint for the parameter: val
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
| """ | ||
| ans = 0 | ||
|
|
||
| def solver(node) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/maximum_sum_bst.py, please provide doctest for the function solver
Please provide type hint for the parameter: node
for more information, see https://pre-commit.ci
…thon into max_sum_binary_tree
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
| ans = 0 | ||
|
|
||
| def solver(node) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/maximum_sum_bst.py, please provide doctest for the function solver
Please provide type hint for the parameter: node
for more information, see https://pre-commit.ci
| @@ -0,0 +1,68 @@ | |||
| class TreeNode: | |||
There was a problem hiding this comment.
Please make this a https://docs.python.org/3/library/dataclasses.html
There was a problem hiding this comment.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
| ans = 0 | ||
|
|
||
| def solver(node) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/maximum_sum_bst.py, please provide doctest for the function solver
Please provide type hint for the parameter: node
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…thon into max_sum_binary_tree
for more information, see https://pre-commit.ci
…thon into max_sum_binary_tree
|
On your computer: |
for more information, see https://pre-commit.ci
…thon into max_sum_binary_tree
for more information, see https://pre-commit.ci
…thon into max_sum_binary_tree
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
algorithms-keeper
bot
removed
the
awaiting reviews
Describe your change:
Checklist: