Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate_filenames.py Shebang python for Windows #12371

Merged
merged 1 commit into from
Nov 15, 2024
Merged

validate_filenames.py Shebang python for Windows #12371

merged 1 commit into from
Nov 15, 2024

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Nov 11, 2024

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 11, 2024
@cclauss cclauss mentioned this pull request Nov 11, 2024
Closed
5 tasks
@cclauss cclauss merged commit e3bd772 into master Nov 15, 2024
6 checks passed
@cclauss cclauss deleted the Shebang-python-for-Windows branch November 15, 2024 13:59
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 15, 2024
@kangaroo-eating-carrots
Copy link

Thank you @cclauss.
Fixes #12352

@kangaroo-eating-carrots kangaroo-eating-carrots mentioned this pull request Nov 18, 2024
Closed
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @kangaroo-eating-carrots @poyea