Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff #12515

Merged
merged 8 commits into from
Jan 12, 2025
Merged

Fix ruff #12515

merged 8 commits into from
Jan 12, 2025

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Fix ruff

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jan 12, 2025
@MaximSmolskiy MaximSmolskiy requested a review from cclauss January 12, 2025 00:34
@MaximSmolskiy
Copy link
Member Author

@cclauss please review and tell me is it a normal situation that last commit to master has green status, but at the same time on new commits to master ruff crashes?

@MaximSmolskiy MaximSmolskiy requested a review from cclauss January 12, 2025 07:20
@cclauss
Copy link
Member

cclauss commented Jan 12, 2025

Ruff is v0.9.1 almost at v1.0 where it will be more stable but for now we can expect some bumps like this. V0.9.0 also added the 2025 stable format which is shared between black and ruff format. We could run ruff only in pre-commit but I like running unpinned in GitHub Actions so we spot the changes.

@cclauss cclauss enabled auto-merge (squash) January 12, 2025 16:04
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cclauss cclauss merged commit b653aee into TheAlgorithms:master Jan 12, 2025
1 check passed
@MaximSmolskiy MaximSmolskiy deleted the fix-ruff branch January 12, 2025 16:19
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants