Skip to content

Add median() function using Quickselect #12676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add median() function using Quickselect #12676

wants to merge 1 commit into from

Conversation

isidroas
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

shruthivinjamuri89
shruthivinjamuri89 suggested changes May 12, 2025
View reviewed changes
Copy link

@shruthivinjamuri89 shruthivinjamuri89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I have added few minor comments.

searches/quick_select.py
@@ -60,3 +60,34 @@ def quick_select(items: list, index: int):
# must be in larger
else:
return quick_select(larger, index - (m + count))


def median(data: list):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an application of the quick_select algorithm, can you move it to its own file?

searches/quick_select.py
else:
low_mid = quick_select(data, mid - 1)
high_mid = quick_select(data, mid)
return (low_mid + high_mid) / 2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add comments.
Especially on the else block.

searches/quick_select.py
"""
mid, rest = divmod(len(data), 2)
if rest:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to remainder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shruthivinjamuri89 shruthivinjamuri89 shruthivinjamuri89 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isidroas @shruthivinjamuri89